[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Fwd: Boolean valueOf instead of new Boolean
From: Otávio_Gonçalves_de_Santana <otaviojava () java ! net>
Date: 2014-05-29 1:50:55
Message-ID: CAPc8kR091RRVu7yBHUiFc5Q-D_Rdzj7h0xKND3T=iO6YgaYY1A () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
---------- Forwarded message ----------
From: roger riggs <roger.riggs@oracle.com>
Date: Tue, May 27, 2014 at 3:02 PM
Subject: Re: Boolean valueOf instead of new Boolean
To: core-libs-dev@openjdk.java.net
Hi Otávio,
I can sponsor these two (Boolean and single char strings) for you.
Because they cross over different repositories and require different reviews
it would be more convenient to process each of them in two batches (client
vs core)
Please can you break out the 'client' changes into a separate webrev?
The client packages are: (java and javax...)
java2d, awt, swing, font, print, beans, media, imageio, applet, sound and
accessibility.
The client webrevs should be posted to awt-dev and the other two to
core-libs, net-dev and servicability-dev.
Thanks, Roger
On 5/27/2014 1:16 PM, Otávio Gonçalves de Santana wrote:
> Can anyone help me as sponsor?
> On May 25, 2014 2:08 AM, "Otávio Gonçalves de Santana" <
> otaviojava@java.net>
> wrote:
>
>
>
--
Atenciosamente.
Otávio Gonçalves de Santana
blog: http://otaviosantana.blogspot.com.br/
twitter: http://twitter.com/otaviojava
site: http://www.otaviojava.com.br
(11) 98255-3513
[Attachment #5 (text/html)]
<div dir="ltr"><br><br><div class="gmail_quote">---------- Forwarded message \
----------<br>From: <b class="gmail_sendername">roger riggs</b> <span \
dir="ltr"><<a href="mailto:roger.riggs@oracle.com">roger.riggs@oracle.com</a>></span><br>
Date: Tue, May 27, 2014 at 3:02 PM<br>Subject: Re: Boolean valueOf instead of new \
Boolean<br>To: <a href="mailto:core-libs-dev@openjdk.java.net">core-libs-dev@openjdk.java.net</a><br><br><br>Hi \
Otávio,<br> <br>
I can sponsor these two (Boolean and single char strings) for you.<br>
<br>
Because they cross over different repositories and require different reviews<br>
it would be more convenient to process each of them in two batches (client vs \
core)<br> <br>
Please can you break out the 'client' changes into a separate webrev?<br>
The client packages are: (java and javax...)<br>
java2d, awt, swing, font, print, beans, media, imageio, applet, sound and \
accessibility.<br> <br>
The client webrevs should be posted to awt-dev and the other two to core-libs, \
net-dev and servicability-dev.<br> <br>
Thanks, Roger<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 5/27/2014 1:16 PM, Otávio Gonçalves de Santana wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Can anyone help me as sponsor?<br>
On May 25, 2014 2:08 AM, "Otávio Gonçalves de Santana" <<a \
href="mailto:otaviojava@java.net" target="_blank">otaviojava@java.net</a>><br> \
wrote:<br> <br>
<br>
</blockquote>
<br>
</div></div></div><br><br clear="all"><div><br></div>-- \
<br>Atenciosamente.<br><br>Otávio Gonçalves de Santana<div><div \
style="text-align:center"><br><div style="text-align:-webkit-auto"><font \
face="Tahoma">blog: </font><a href="http://otaviosantana.blogspot.com.br/" \
style="text-align:center" \
target="_blank">http://otaviosantana.blogspot.com.br/</a></div>
<div style="text-align:-webkit-auto">twitter: <a \
href="http://twitter.com/otaviojava" \
target="_blank">http://twitter.com/otaviojava</a></div><div \
style="text-align:-webkit-auto">site: <a href="http://www.otaviojava.com.br/" \
target="_blank">http://<span \
style="text-align:-webkit-auto">www.otaviojava.com.br</span></a></div>
<div style="text-align:-webkit-auto">(11) \
98255-3513</div><div><br></div></div></div> </div>
--f46d0438921b2618ef04fa802a58--
["core_sun_single_char.diff" (text/plain)]
diff -r e323c74edabd src/share/classes/sun/applet/AppletClassLoader.java
--- a/src/share/classes/sun/applet/AppletClassLoader.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/sun/applet/AppletClassLoader.java Tue May 27 21:47:24 2014 \
-0300 @@ -168,7 +168,7 @@
*/
protected Class findClass(String name) throws ClassNotFoundException {
- int index = name.indexOf(";");
+ int index = name.indexOf(';');
String cookie = "";
if(index != -1) {
cookie = name.substring(index, name.length());
@@ -608,7 +608,7 @@
// deal with URL rewriting
String cookie = null;
- int index = name.indexOf(";");
+ int index = name.indexOf(';');
if(index != -1) {
cookie = name.substring(index, name.length());
name = name.substring(0, index);
diff -r e323c74edabd src/share/classes/sun/awt/FontConfiguration.java
--- a/src/share/classes/sun/awt/FontConfiguration.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/awt/FontConfiguration.java Tue May 27 21:47:24 2014 -0300
@@ -272,9 +272,9 @@
if (configFile != null) {
return configFile;
}
- int decimalPointIndex = osVersion.indexOf(".");
+ int decimalPointIndex = osVersion.indexOf('.');
if (decimalPointIndex != -1) {
- osMajorVersion = osVersion.substring(0, osVersion.indexOf("."));
+ osMajorVersion = osVersion.substring(0, osVersion.indexOf('.'));
configFile = findImpl(baseName + "." + osName + "." + \
osMajorVersion); if (configFile != null) {
return configFile;
diff -r e323c74edabd src/share/classes/sun/font/Type1Font.java
--- a/src/share/classes/sun/font/Type1Font.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/font/Type1Font.java Tue May 27 21:47:24 2014 -0300
@@ -492,7 +492,7 @@
//Conversion: Expand abbreviations in style portion (everything after '-'),
// replace '-' with space and insert missing spaces
- pos = name.indexOf("-");
+ pos = name.indexOf('-');
if (pos >= 0) {
res = expandName(name.substring(0, pos), false);
res += " " + expandName(name.substring(pos+1), true);
@@ -513,8 +513,8 @@
//Conversion: Truncate style portion (everything after '-')
// and insert missing spaces
- if (tmp.indexOf("-") > 0) {
- tmp = tmp.substring(0, tmp.indexOf("-"));
+ if (tmp.indexOf('-') > 0) {
+ tmp = tmp.substring(0, tmp.indexOf('-'));
}
return expandName(tmp, false);
diff -r e323c74edabd src/share/classes/sun/jvmstat/monitor/AbstractMonitor.java
--- a/src/share/classes/sun/jvmstat/monitor/AbstractMonitor.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/jvmstat/monitor/AbstractMonitor.java Tue May 27 21:47:24 \
2014 -0300 @@ -84,7 +84,7 @@
* {@inheritDoc}
*/
public String getBaseName() {
- int baseIndex = name.lastIndexOf(".")+1;
+ int baseIndex = name.lastIndexOf('.') + 1;
return name.substring(baseIndex);
}
diff -r e323c74edabd src/share/classes/sun/jvmstat/monitor/HostIdentifier.java
--- a/src/share/classes/sun/jvmstat/monitor/HostIdentifier.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/jvmstat/monitor/HostIdentifier.java Tue May 27 21:47:24 \
2014 -0300 @@ -138,8 +138,8 @@
String frag = u.getFragment();
URI u2 = null;
- int c1index = uriString.indexOf(":");
- int c2index = uriString.lastIndexOf(":");
+ int c1index = uriString.indexOf(':');
+ int c2index = uriString.lastIndexOf(':');
if (c2index != c1index) {
/*
* this is the scheme:hostname:port case. Attempt to
diff -r e323c74edabd \
src/share/classes/sun/management/snmp/jvminstr/NotificationTargetImpl.java
--- a/src/share/classes/sun/management/snmp/jvminstr/NotificationTargetImpl.java Wed \
Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/management/snmp/jvminstr/NotificationTargetImpl.java Tue \
May 27 21:47:24 2014 -0300 @@ -70,8 +70,8 @@
String addrStr;
if (target.startsWith("[")) {
- final int index = target.indexOf("]");
- final int index2 = target.lastIndexOf(":");
+ final int index = target.indexOf(']');
+ final int index2 = target.lastIndexOf(':');
if(index == -1)
throw new IllegalArgumentException("Host starts with [ but " +
"does not end with ]");
@@ -85,8 +85,8 @@
if (addrStr.startsWith("["))
throw new IllegalArgumentException("More than one [[...]]");
} else {
- final int index = target.indexOf(":");
- final int index2 = target.lastIndexOf(":");
+ final int index = target.indexOf(':');
+ final int index2 = target.lastIndexOf(':');
if(index == -1) throw new
IllegalArgumentException("Missing port separator \":\"");
addrStr = target.substring(0, index);
@@ -98,7 +98,7 @@
address = InetAddress.getByName(addrStr);
//THE CHECK SHOULD BE STRONGER!!!
- final int index = target.lastIndexOf(":");
+ final int index = target.lastIndexOf(':');
community = target.substring(index + 1, target.length());
diff -r e323c74edabd src/share/classes/sun/misc/ExtensionInfo.java
--- a/src/share/classes/sun/misc/ExtensionInfo.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/misc/ExtensionInfo.java Tue May 27 21:47:24 2014 -0300
@@ -273,8 +273,8 @@
else
{
// Look for index of "." in the string
- int sIdx = source.indexOf(".");
- int tIdx = target.indexOf(".");
+ int sIdx = source.indexOf('.');
+ int tIdx = target.indexOf('.');
if (sIdx == -1)
sIdx = source.length() - 1;
@@ -304,10 +304,10 @@
String versionError = mf.format(args);
// Look for "-" for pre-release
- int prIndex = token.indexOf("-");
+ int prIndex = token.indexOf('-');
// Look for "_" for patch release
- int patchIndex = token.indexOf("_");
+ int patchIndex = token.indexOf('_');
if (prIndex == -1 && patchIndex == -1)
{
diff -r e323c74edabd src/share/classes/sun/misc/JarIndex.java
--- a/src/share/classes/sun/misc/JarIndex.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/misc/JarIndex.java Tue May 27 21:47:24 2014 -0300
@@ -172,7 +172,7 @@
if ((jarFiles = indexMap.get(fileName)) == null) {
/* try the package name again */
int pos;
- if((pos = fileName.lastIndexOf("/")) != -1) {
+ if((pos = fileName.lastIndexOf('/')) != -1) {
jarFiles = indexMap.get(fileName.substring(0, pos));
}
}
@@ -195,7 +195,7 @@
public void add(String fileName, String jarName) {
String packageName;
int pos;
- if((pos = fileName.lastIndexOf("/")) != -1) {
+ if((pos = fileName.lastIndexOf('/')) != -1) {
packageName = fileName.substring(0, pos);
} else {
packageName = fileName;
diff -r e323c74edabd src/share/classes/sun/misc/URLClassPath.java
--- a/src/share/classes/sun/misc/URLClassPath.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/misc/URLClassPath.java Tue May 27 21:47:24 2014 -0300
@@ -793,7 +793,7 @@
boolean validIndex(final String name) {
String packageName = name;
int pos;
- if((pos = name.lastIndexOf("/")) != -1) {
+ if((pos = name.lastIndexOf('/')) != -1) {
packageName = name.substring(0, pos);
}
@@ -803,7 +803,7 @@
while (enum_.hasMoreElements()) {
entry = enum_.nextElement();
entryName = entry.getName();
- if((pos = entryName.lastIndexOf("/")) != -1)
+ if((pos = entryName.lastIndexOf('/')) != -1)
entryName = entryName.substring(0, pos);
if (entryName.equals(packageName)) {
return true;
@@ -900,7 +900,7 @@
*/
JarIndex newIndex = newLoader.getIndex();
if(newIndex != null) {
- int pos = jarName.lastIndexOf("/");
+ int pos = jarName.lastIndexOf('/');
newIndex.merge(this.index, (pos == -1 ?
null : jarName.substring(0, pos + 1)));
}
diff -r e323c74edabd src/share/classes/sun/net/ftp/impl/FtpClient.java
--- a/src/share/classes/sun/net/ftp/impl/FtpClient.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/sun/net/ftp/impl/FtpClient.java Tue May 27 21:47:24 2014 \
-0300 @@ -259,7 +259,7 @@
d = null;
}
if (d != null && time != null) {
- int c = time.indexOf(":");
+ int c = time.indexOf(':');
now.setTime(d);
now.set(Calendar.HOUR, Integer.parseInt(time.substring(0, c)));
now.set(Calendar.MINUTE, Integer.parseInt(time.substring(c + \
1))); @@ -295,7 +295,7 @@
public FtpDirEntry parseLine(String line) {
String name = null;
- int i = line.lastIndexOf(";");
+ int i = line.lastIndexOf(';');
if (i > 0) {
name = line.substring(i + 1).trim();
line = line.substring(0, i);
@@ -306,7 +306,7 @@
FtpDirEntry file = new FtpDirEntry(name);
while (!line.isEmpty()) {
String s;
- i = line.indexOf(";");
+ i = line.indexOf(';');
if (i > 0) {
s = line.substring(0, i);
line = line.substring(i + 1);
@@ -314,7 +314,7 @@
s = line;
line = "";
}
- i = s.indexOf("=");
+ i = s.indexOf('=');
if (i > 0) {
String fact = s.substring(0, i);
String value = s.substring(i + 1);
diff -r e323c74edabd \
src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java
--- a/src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/sun/net/spi/nameservice/dns/DNSNameService.java Tue May 27 \
21:47:24 2014 -0300 @@ -325,7 +325,7 @@
while (i.hasNext()) {
String parentDomain = i.next();
int start = 0;
- while ((start = parentDomain.indexOf(".")) != -1
+ while ((start = parentDomain.indexOf('.')) != -1
&& start < parentDomain.length() -1) {
try {
results = resolve(ctx, host+"."+parentDomain, ids, 0);
diff -r e323c74edabd src/share/classes/sun/net/util/IPAddressUtil.java
--- a/src/share/classes/sun/net/util/IPAddressUtil.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/sun/net/util/IPAddressUtil.java Tue May 27 21:47:24 2014 \
-0300 @@ -149,7 +149,7 @@
byte[] dst = new byte[INADDR16SZ];
int srcb_length = srcb.length;
- int pc = src.indexOf ("%");
+ int pc = src.indexOf ('%');
if (pc == srcb_length -1) {
return null;
}
diff -r e323c74edabd src/share/classes/sun/net/www/ParseUtil.java
--- a/src/share/classes/sun/net/www/ParseUtil.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/net/www/ParseUtil.java Tue May 27 21:47:24 2014 -0300
@@ -356,8 +356,8 @@
* because we must not quote a literal IPv6 address
*/
if (opaquePart.startsWith("//[")) {
- int end = opaquePart.indexOf("]");
- if (end != -1 && opaquePart.indexOf(":")!=-1) {
+ int end = opaquePart.indexOf(']');
+ if (end != -1 && opaquePart.indexOf(':')!=-1) {
String doquote, dontquote;
if (end == opaquePart.length()) {
dontquote = opaquePart;
@@ -408,8 +408,8 @@
} else if (authority != null) {
sb.append("//");
if (authority.startsWith("[")) {
- int end = authority.indexOf("]");
- if (end != -1 && authority.indexOf(":")!=-1) {
+ int end = authority.indexOf(']');
+ if (end != -1 && authority.indexOf(':')!=-1) {
String doquote, dontquote;
if (end == authority.length()) {
dontquote = authority;
diff -r e323c74edabd src/share/classes/sun/reflect/misc/ReflectUtil.java
--- a/src/share/classes/sun/reflect/misc/ReflectUtil.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/sun/reflect/misc/ReflectUtil.java Tue May 27 21:47:24 2014 \
-0300 @@ -341,6 +341,6 @@
* (not to be confused with a Java Language anonymous inner class).
*/
public static boolean isVMAnonymousClass(Class<?> cls) {
- return cls.getName().indexOf("/") > -1;
+ return cls.getName().indexOf('/') > -1;
}
}
diff -r e323c74edabd src/share/classes/sun/rmi/runtime/Log.java
--- a/src/share/classes/sun/rmi/runtime/Log.java Wed Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/sun/rmi/runtime/Log.java Tue May 27 21:47:24 2014 -0300
@@ -434,7 +434,7 @@
* Mimic old log messages that only contain unqualified names.
*/
private static String unqualifiedName(String name) {
- int lastDot = name.lastIndexOf(".");
+ int lastDot = name.lastIndexOf('.');
if (lastDot >= 0) {
name = name.substring(lastDot + 1);
}
diff -r e323c74edabd src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
--- a/src/share/classes/sun/rmi/transport/proxy/CGIHandler.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/rmi/transport/proxy/CGIHandler.java Tue May 27 21:47:24 \
2014 -0300 @@ -141,7 +141,7 @@
{
try {
String command, param;
- int delim = QueryString.indexOf("=");
+ int delim = QueryString.indexOf('=');
if (delim == -1) {
command = QueryString;
param = "";
diff -r e323c74edabd src/share/classes/sun/security/jgss/wrapper/Krb5Util.java
--- a/src/share/classes/sun/security/jgss/wrapper/Krb5Util.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/security/jgss/wrapper/Krb5Util.java Tue May 27 21:47:24 \
2014 -0300 @@ -39,7 +39,7 @@
static String getTGSName(GSSNameElement name)
throws GSSException {
String krbPrinc = name.getKrbName();
- int atIndex = krbPrinc.indexOf("@");
+ int atIndex = krbPrinc.indexOf('@');
String realm = krbPrinc.substring(atIndex + 1);
StringBuffer buf = new StringBuffer("krbtgt/");
buf.append(realm).append('@').append(realm);
diff -r e323c74edabd src/share/classes/sun/security/provider/PolicyFile.java
--- a/src/share/classes/sun/security/provider/PolicyFile.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/security/provider/PolicyFile.java Tue May 27 21:47:24 \
2014 -0300 @@ -1856,7 +1856,7 @@
int colonIndex;
String prefix = value;
String suffix;
- if ((colonIndex = value.indexOf(":")) != -1) {
+ if ((colonIndex = value.indexOf(':')) != -1) {
prefix = value.substring(0, colonIndex);
}
diff -r e323c74edabd src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java
--- a/src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java Tue May 27 \
21:47:24 2014 -0300 @@ -338,7 +338,7 @@
}
String sigType;
if (keyType.contains("_")) {
- int k = keyType.indexOf("_");
+ int k = keyType.indexOf('_');
sigType = keyType.substring(k + 1);
keyType = keyType.substring(0, k);
} else {
diff -r e323c74edabd src/share/classes/sun/security/ssl/X509KeyManagerImpl.java
--- a/src/share/classes/sun/security/ssl/X509KeyManagerImpl.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/security/ssl/X509KeyManagerImpl.java Tue May 27 21:47:24 \
2014 -0300 @@ -302,7 +302,7 @@
final String sigKeyAlgorithm;
KeyType(String algorithm) {
- int k = algorithm.indexOf("_");
+ int k = algorithm.indexOf('_');
if (k == -1) {
keyAlgorithm = algorithm;
sigKeyAlgorithm = null;
diff -r e323c74edabd src/share/classes/sun/security/util/HostnameChecker.java
--- a/src/share/classes/sun/security/util/HostnameChecker.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/security/util/HostnameChecker.java Tue May 27 21:47:24 \
2014 -0300 @@ -300,8 +300,8 @@
template = template.toLowerCase(Locale.ENGLISH);
// Retreive leftmost component
- int templateIdx = template.indexOf(".");
- int nameIdx = name.indexOf(".");
+ int templateIdx = template.indexOf('.');
+ int nameIdx = name.indexOf('.');
if (templateIdx == -1)
templateIdx = template.length();
@@ -326,7 +326,7 @@
*/
private static boolean matchWildCards(String name, String template) {
- int wildcardIdx = template.indexOf("*");
+ int wildcardIdx = template.indexOf('*');
if (wildcardIdx == -1)
return name.equals(template);
@@ -349,7 +349,7 @@
// update the match scope
name = name.substring(beforeStartIdx + beforeWildcard.length());
- wildcardIdx = afterWildcard.indexOf("*");
+ wildcardIdx = afterWildcard.indexOf('*');
}
return name.endsWith(afterWildcard);
}
diff -r e323c74edabd src/share/classes/sun/security/util/SignatureFileVerifier.java
--- a/src/share/classes/sun/security/util/SignatureFileVerifier.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/sun/security/util/SignatureFileVerifier.java Tue May 27 \
21:47:24 2014 -0300 @@ -98,7 +98,7 @@
} finally {
Providers.stopJarVerification(obj);
}
- this.name = name.substring(0, name.lastIndexOf("."))
+ this.name = name.substring(0, name.lastIndexOf('.'))
.toUpperCase(Locale.ENGLISH);
this.md = md;
this.signerCache = signerCache;
diff -r e323c74edabd src/share/classes/sun/security/x509/CRLExtensions.java
--- a/src/share/classes/sun/security/x509/CRLExtensions.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/sun/security/x509/CRLExtensions.java Tue May 27 21:47:24 2014 \
-0300 @@ -185,7 +185,7 @@
String name;
String id = attr.getPrefix();
if (id.equalsIgnoreCase(X509CertImpl.NAME)) { // fully qualified
- int index = alias.lastIndexOf(".");
+ int index = alias.lastIndexOf('.');
name = alias.substring(index + 1);
} else
name = alias;
diff -r e323c74edabd src/share/classes/sun/tools/jconsole/ConnectDialog.java
--- a/src/share/classes/sun/tools/jconsole/ConnectDialog.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/ConnectDialog.java Tue May 27 21:47:24 \
2014 -0300 @@ -325,7 +325,7 @@
} else {
String host = remoteTF.getText().trim();
String port = "0";
- int index = host.lastIndexOf(":");
+ int index = host.lastIndexOf(':');
if (index >= 0) {
port = host.substring(index + 1);
host = host.substring(0, index);
diff -r e323c74edabd src/share/classes/sun/tools/jconsole/inspector/Utils.java
--- a/src/share/classes/sun/tools/jconsole/inspector/Utils.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/Utils.java Tue May 27 21:47:24 \
2014 -0300 @@ -210,7 +210,7 @@
public static String getArrayClassName(String name) {
String className = null;
if (name.startsWith("[")) {
- int index = name.lastIndexOf("[");
+ int index = name.lastIndexOf('[');
className = name.substring(index, name.length());
if (className.startsWith("[L")) {
className = className.substring(2, className.length() - 1);
@@ -241,7 +241,7 @@
if (className == null) {
return name;
}
- int index = name.lastIndexOf("[");
+ int index = name.lastIndexOf('[');
StringBuilder brackets = new StringBuilder(className);
for (int i = 0; i <= index; i++) {
brackets.append("[]");
diff -r e323c74edabd src/share/classes/sun/tools/jconsole/inspector/XOperations.java
--- a/src/share/classes/sun/tools/jconsole/inspector/XOperations.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/XOperations.java Tue May 27 \
21:47:24 2014 -0300 @@ -112,7 +112,7 @@
if (methodLabel.getText().length() > 20) {
methodLabel.setText(methodLabel.getText().
substring(methodLabel.getText().
- lastIndexOf(".") + 1,
+ lastIndexOf('.') + 1,
methodLabel.getText().length()));
}
diff -r e323c74edabd src/share/classes/sun/tools/jconsole/inspector/XTree.java
--- a/src/share/classes/sun/tools/jconsole/inspector/XTree.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/XTree.java Tue May 27 21:47:24 \
2014 -0300 @@ -475,7 +475,7 @@
private static Map<String, String> extractKeyValuePairs(
String props, ObjectName mbean) {
Map<String, String> map = new LinkedHashMap<String, String>();
- int eq = props.indexOf("=");
+ int eq = props.indexOf('=');
while (eq != -1) {
String key = props.substring(0, eq);
String value = mbean.getKeyProperty(key);
@@ -484,7 +484,7 @@
if (props.startsWith(",")) {
props = props.substring(1);
}
- eq = props.indexOf("=");
+ eq = props.indexOf('=');
}
return map;
}
@@ -821,7 +821,7 @@
}
private void buildKeyValue() {
- int index = tokenValue.indexOf("=");
+ int index = tokenValue.indexOf('=');
if (index < 0) {
key = tokenValue;
value = tokenValue;
["core_com_sun_single_char.diff" (text/plain)]
diff -r e323c74edabd src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java
--- a/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java Tue May 27 21:46:45 \
2014 -0300 @@ -547,7 +547,7 @@
i = strLowerCase.indexOf("<stringvalue>", i);
if (i > 0) {
i += "<stringvalue>".length();
- int i2 = str.indexOf("<", i);
+ int i2 = str.indexOf('<', i);
return str.substring(i, i2);
}
}
diff -r e323c74edabd src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java
--- a/src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java Tue May 27 \
21:46:45 2014 -0300 @@ -512,7 +512,7 @@
}
static String qualifiedStringValue(String s1, String s234) {
// Qualification by dot must decompose uniquely. Second string might \
already be qualified.
- assert(s1.indexOf(".") < 0);
+ assert(s1.indexOf('.') < 0);
return s1+"."+s234;
}
diff -r e323c74edabd src/share/classes/com/sun/jndi/cosnaming/CorbanameUrl.java
--- a/src/share/classes/com/sun/jndi/cosnaming/CorbanameUrl.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/com/sun/jndi/cosnaming/CorbanameUrl.java Tue May 27 21:46:45 \
2014 -0300 @@ -102,7 +102,7 @@
}
location = url.substring(addrStart, addrEnd);
- int keyStart = location.indexOf("/");
+ int keyStart = location.indexOf('/');
if (keyStart >= 0) {
// Has key string
if (keyStart == (location.length() -1)) {
diff -r e323c74edabd src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java
--- a/src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java Tue May 27 \
21:46:45 2014 -0300 @@ -336,7 +336,7 @@
String url = "rmi://";
// Enclose IPv6 literal address in '[' and ']'
- url = (host.indexOf(":") > -1) ? url + "[" + host + "]" :
+ url = (host.indexOf(':') > -1) ? url + "[" + host + "]" :
url + host;
if (port > 0) {
url += ":" + Integer.toString(port);
diff -r e323c74edabd \
src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java
--- a/src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java Tue May 27 \
21:46:45 2014 -0300 @@ -149,7 +149,7 @@
* foo:rest/of/name foo:
*/
protected String getURLPrefix(String url) throws NamingException {
- int start = url.indexOf(":");
+ int start = url.indexOf(':');
if (start < 0) {
throw new OperationNotSupportedException("Invalid URL: " + url);
@@ -160,7 +160,7 @@
start += 2; // skip double slash
// find last slash
- int posn = url.indexOf("/", start);
+ int posn = url.indexOf('/', start);
if (posn >= 0) {
start = posn;
} else {
diff -r e323c74edabd src/share/classes/com/sun/rmi/rmid/ExecOptionPermission.java
--- a/src/share/classes/com/sun/rmi/rmid/ExecOptionPermission.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/rmi/rmid/ExecOptionPermission.java Tue May 27 \
21:46:45 2014 -0300 @@ -303,7 +303,7 @@
offset = pname.length() - 1;
- while ((last = pname.lastIndexOf(".", offset)) != -1) {
+ while ((last = pname.lastIndexOf('.', offset)) != -1) {
pname = pname.substring(0, last+1) + "*";
x = permissions.get(pname);
@@ -318,7 +318,7 @@
pname = p.getName();
offset = pname.length() - 1;
- while ((last = pname.lastIndexOf("=", offset)) != -1) {
+ while ((last = pname.lastIndexOf('=', offset)) != -1) {
pname = pname.substring(0, last+1) + "*";
x = permissions.get(pname);
diff -r e323c74edabd src/share/classes/com/sun/rowset/CachedRowSetImpl.java
--- a/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/com/sun/rowset/CachedRowSetImpl.java Tue May 27 21:46:45 2014 \
-0300 @@ -6831,7 +6831,7 @@
// table name else isolate table name.
indexFrom = command.toLowerCase().indexOf("from");
- indexComma = command.indexOf(",", indexFrom);
+ indexComma = command.indexOf(',', indexFrom);
if(indexComma == -1) {
// implies only one table
diff -r e323c74edabd src/share/classes/com/sun/rowset/JoinRowSetImpl.java
--- a/src/share/classes/com/sun/rowset/JoinRowSetImpl.java Wed Apr 23 11:35:40 2014 \
-0700
+++ b/src/share/classes/com/sun/rowset/JoinRowSetImpl.java Tue May 27 21:46:45 2014 \
-0300 @@ -910,7 +910,7 @@
// now remove the last ","
strWhereClause = strWhereClause.substring
- (0, strWhereClause.lastIndexOf(","));
+ (0, strWhereClause.lastIndexOf(','));
// Add from clause
strWhereClause = strWhereClause.concat(" from ");
@@ -920,7 +920,7 @@
//Remove the last ","
strWhereClause = strWhereClause.substring
- (0, strWhereClause.lastIndexOf(","));
+ (0, strWhereClause.lastIndexOf(','));
// Add the where clause
strWhereClause = strWhereClause.concat(" where ");
diff -r e323c74edabd \
src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
--- a/src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java Tue May 27 \
21:46:45 2014 -0300 @@ -240,7 +240,7 @@
// Remove the string after "@xxxx"
// before writing it to the xml file.
String strProviderInstance = (caller.getSyncProvider()).toString();
- String strProvider = strProviderInstance.substring(0, \
(caller.getSyncProvider()).toString().indexOf("@")); + String strProvider \
= strProviderInstance.substring(0, \
(caller.getSyncProvider()).toString().indexOf('@'));
propString("sync-provider-name", strProvider);
propString("sync-provider-vendor", "Oracle Corporation");
diff -r e323c74edabd \
src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java
--- a/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Wed Apr \
23 11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Tue May \
27 21:46:45 2014 -0300 @@ -1147,7 +1147,7 @@
if (nullValue) {
rs.setSyncProvider(null);
} else {
- String str = s.substring(0,s.indexOf("@")+1);
+ String str = s.substring(0,s.indexOf('@')+1);
rs.setSyncProvider(str);
}
break;
diff -r e323c74edabd src/share/classes/com/sun/rowset/internal/XmlResolver.java
--- a/src/share/classes/com/sun/rowset/internal/XmlResolver.java Wed Apr 23 11:35:40 \
2014 -0700
+++ b/src/share/classes/com/sun/rowset/internal/XmlResolver.java Tue May 27 21:46:45 \
2014 -0300 @@ -39,7 +39,7 @@
public class XmlResolver implements EntityResolver {
public InputSource resolveEntity(String publicId, String systemId) {
- String schemaName = systemId.substring(systemId.lastIndexOf("/"));
+ String schemaName = systemId.substring(systemId.lastIndexOf('/'));
if(systemId.startsWith("http://java.sun.com/xml/ns/jdbc")) {
return new \
InputSource(this.getClass().getResourceAsStream(schemaName));
diff -r e323c74edabd \
src/share/classes/com/sun/security/auth/module/JndiLoginModule.java
--- a/src/share/classes/com/sun/security/auth/module/JndiLoginModule.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/security/auth/module/JndiLoginModule.java Tue May 27 \
21:46:45 2014 -0300 @@ -694,7 +694,7 @@
throw new LoginException("Error: no CallbackHandler available " +
"to garner authentication information from the user");
- String protocol = userProvider.substring(0, userProvider.indexOf(":"));
+ String protocol = userProvider.substring(0, userProvider.indexOf(':'));
Callback[] callbacks = new Callback[2];
callbacks[0] = new NameCallback(protocol + " "
diff -r e323c74edabd \
src/share/classes/com/sun/security/auth/module/LdapLoginModule.java
--- a/src/share/classes/com/sun/security/auth/module/LdapLoginModule.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/security/auth/module/LdapLoginModule.java Tue May 27 \
21:46:45 2014 -0300 @@ -400,7 +400,7 @@
// Add any JNDI properties to the environment
for (String key : options.keySet()) {
- if (key.indexOf(".") > -1) {
+ if (key.indexOf('.') > -1) {
ldapEnvironment.put(key, options.get(key));
}
}
diff -r e323c74edabd \
src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java
--- a/src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java Wed \
Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java Tue \
May 27 21:46:45 2014 -0300 @@ -857,7 +857,7 @@
bpSpec = runtime.createClassLineBreakpoint(classId, lineNumber);
} else {
// Try stripping method from class.method token.
- int idot = token.lastIndexOf(".");
+ int idot = token.lastIndexOf('.');
if ( (idot <= 0) || /* No dot or dot in first char */
(idot >= token.length() - 1) ) { /* dot in last char */
return null;
diff -r e323c74edabd src/share/classes/com/sun/tools/example/debug/tty/Commands.java
--- a/src/share/classes/com/sun/tools/example/debug/tty/Commands.java Wed Apr 23 \
11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/tools/example/debug/tty/Commands.java Tue May 27 \
21:46:45 2014 -0300 @@ -1079,7 +1079,7 @@
}
} else {
// Try stripping method from class.method token.
- int idot = token.lastIndexOf(".");
+ int idot = token.lastIndexOf('.');
if ( (idot <= 0) || /* No dot or dot in first \
char */
(idot >= token.length() - 1) ) { /* dot in last char */
printBreakpointCommandUsage(atForm, inForm);
diff -r e323c74edabd \
src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java
--- a/src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java Wed \
Apr 23 11:35:40 2014 -0700
+++ b/src/share/classes/com/sun/tools/hat/internal/server/AllClassesQuery.java Tue \
May 27 21:46:45 2014 -0300 @@ -67,7 +67,7 @@
continue;
}
String name = clazz.getName();
- int pos = name.lastIndexOf(".");
+ int pos = name.lastIndexOf('.');
String pkg;
if (name.startsWith("[")) { // Only in ancient heap dumps
pkg = "<Arrays>";
["core_boolean_instance.diff" (text/plain)]
iff -r 28d1de89ff27 src/share/classes/sun/font/SunFontManager.java
--- a/src/share/classes/sun/font/SunFontManager.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/font/SunFontManager.java Sat May 24 10:55:43 2014 -0300
@@ -2871,8 +2871,7 @@
new java.security.PrivilegedAction<Object>() {
public Object run() {
SecurityManager sm = System.getSecurityManager();
- return new Boolean
- (sm instanceof sun.applet.AppletSecurity);
+ return sm instanceof sun.applet.AppletSecurity;
}
});
return appletSM.booleanValue();
diff -r 28d1de89ff27 src/share/classes/sun/management/StackTraceElementCompositeData.java
--- a/src/share/classes/sun/management/StackTraceElementCompositeData.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/management/StackTraceElementCompositeData.java Sat May 24 10:55:43 2014 -0300
@@ -68,7 +68,7 @@
ste.getMethodName(),
ste.getFileName(),
new Integer(ste.getLineNumber()),
- new Boolean(ste.isNativeMethod()),
+ ste.isNativeMethod(),
};
try {
return new CompositeDataSupport(stackTraceElementCompositeType,
diff -r 28d1de89ff27 src/share/classes/sun/management/ThreadInfoCompositeData.java
--- a/src/share/classes/sun/management/ThreadInfoCompositeData.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/management/ThreadInfoCompositeData.java Sat May 24 10:55:43 2014 -0300
@@ -120,8 +120,8 @@
new Long(threadInfo.getLockOwnerId()),
threadInfo.getLockOwnerName(),
stackTraceData,
- new Boolean(threadInfo.isSuspended()),
- new Boolean(threadInfo.isInNative()),
+ threadInfo.isSuspended(),
+ threadInfo.isInNative(),
lockedMonitorsData,
lockedSyncsData,
};
diff -r 28d1de89ff27 src/share/classes/sun/management/VMOptionCompositeData.java
--- a/src/share/classes/sun/management/VMOptionCompositeData.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/management/VMOptionCompositeData.java Sat May 24 10:55:43 2014 -0300
@@ -59,7 +59,7 @@
final Object[] vmOptionItemValues = {
option.getName(),
option.getValue(),
- new Boolean(option.isWriteable()),
+ option.isWriteable(),
option.getOrigin().toString(),
};
diff -r 28d1de89ff27 src/share/classes/sun/security/jgss/GSSManagerImpl.java
--- a/src/share/classes/sun/security/jgss/GSSManagerImpl.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/security/jgss/GSSManagerImpl.java Sat May 24 10:55:43 2014 -0300
@@ -50,8 +50,8 @@
if (osname.startsWith("SunOS") ||
osname.contains("OS X") ||
osname.startsWith("Linux")) {
- return new Boolean(System.getProperty
- (USE_NATIVE_PROP));
+ return Boolean.valueOf(System.getProperty
+ (USE_NATIVE_PROP));
}
return Boolean.FALSE;
}
diff -r 28d1de89ff27 src/share/classes/sun/security/provider/PolicyFile.java
--- a/src/share/classes/sun/security/provider/PolicyFile.java Thu May 22 12:54:02 2014 -0700
+++ b/src/share/classes/sun/security/provider/PolicyFile.java Sat May 24 10:55:43 2014 -0300
@@ -1271,7 +1271,7 @@
Boolean imp = AccessController.doPrivileged
(new PrivilegedAction<Boolean>() {
public Boolean run() {
- return new Boolean(entry.getCodeSource().implies(cs));
+ return entry.getCodeSource().implies(cs);
}
});
if (!imp.booleanValue()) {
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic