[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 8043915: Tests get ClassNotFoundException: com.oracle.java.testlibrary.StreamPumper
From:       Peter Allwin <peter.allwin () oracle ! com>
Date:       2014-05-30 12:08:45
Message-ID: A6119B80-9FA9-43AB-8A92-F91FA5913EDD () oracle ! com
[Download RAW message or body]

Hi Katja,

Is it necessary to @build classes used in @run statements? I see you added it to some \
but GetObjectSizeOverflow.java is missing ClassFileInstaller.


Other than that it looks good!

Thanks,
/peter


On 28 May 2014, at 13:58, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> \
wrote:

> Hi,
> 
> Could I please have a review of this fix.
> 
> webrev: http://cr.openjdk.java.net/~ykantser/8043915/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8043915
> 
> When using @library in a JTreg test even @build need to be specify for all library \
> files used by the test. If @build is not specified it can lead to intermittent \
> failures when for example running tests concurrently, since javac implicit \
> compilation and @library and -concurrency don't play well together. 
> Verified locally.
> 
> Thanks,
> Katja


[prev in list] [next in list] [prev in thread] [next in thread]