[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8043637 compiler/ciReplay/TestSA.sh: java.lang.InternalError: missing reason for 17
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2014-05-21 18:11:48
Message-ID: F6612645-DC8C-499F-985D-EAAD2A76B9FB () oracle ! com
[Download RAW message or body]

Great! I’ll close my bug as a dup of 8026694.

/Staffan

On 21 maj 2014, at 18:32, Roland Westrelin <roland.westrelin@oracle.com> wrote:

> Hi Staffan,
> 
> > Please review this fix for a problem with compiler/ciReplay/TestSA.sh. It fails \
> > with an exception because SA can’t find the values for some the enum entries in \
> > Deoptimization::DeoptReason since they are missing from vmStructs.cpp. The patch \
> > below adds them. 
> > bug: https://bugs.openjdk.java.net/browse/JDK-8043637
> 
> This is already fixed in hotspot-comp AFAICT.
> 
> Roland.
> 
> > 
> > Thanks,
> > /Staffan
> > 
> > 
> > diff --git a/src/share/vm/runtime/vmStructs.cpp \
> >                 b/src/share/vm/runtime/vmStructs.cpp
> > --- a/src/share/vm/runtime/vmStructs.cpp
> > +++ b/src/share/vm/runtime/vmStructs.cpp
> > @@ -2498,6 +2498,9 @@
> > declare_constant(Deoptimization::Reason_age)                            \
> > declare_constant(Deoptimization::Reason_predicate)                      \
> > declare_constant(Deoptimization::Reason_loop_limit_check)               \
> > +  declare_constant(Deoptimization::Reason_speculate_class_check)          \
> > +  declare_constant(Deoptimization::Reason_speculate_null_check)           \
> > +  declare_constant(Deoptimization::Reason_rtm_state_change)               \
> > declare_constant(Deoptimization::Reason_LIMIT)                          \
> > declare_constant(Deoptimization::Reason_RECORDED_LIMIT)                 \
> > \
> 


[prev in list] [next in list] [prev in thread] [next in thread]