[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    NEED SECOND! Re: RFR(M): JDK-8041498 Remove npt library
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2014-05-20 13:45:52
Message-ID: 537B5C90.9030300 () oracle ! com
[Download RAW message or body]

Hi Everybody,

Need second reviewer!

http://cr.openjdk.java.net/~dsamersoff/JDK-8041498/webrev.02/

-Dmitry


On 2014-04-23 19:03, Dmitry Samersoff wrote:
> Hi Everybody,
> 
> Please review the fix that removes npt library from jdk.
> 
> CR link:
> 
>   https://bugs.openjdk.java.net/browse/JDK-8041498
> 
> Webrev:
> 
>   http://cr.openjdk.java.net/~dsamersoff/JDK-8041498/webrev.01/
> 
> 
> Testing:
> 
>   nsk.jdwp
> 
>   I plan to submit a separate aurora run when I get all concerns.
> 
> Fix details:
> 
> * Today libnpt is a set of UTF related function and only few of them is
>   actually used. The only users of npt is JDWP and hprof. So it's not
>   necessary to keep it as a separate library.
> 
> * Relevant code moved from npt to src/share/back/utf_util.c
>   platfrom specific part is under #ifdef _WINDOWS initialization step
>   is removed.
> 
> * hprof changed to don't do any conversion.
> 
>   The only place where hrpof care about encoding is an output
>   filename. Conversion from platform to UTF8 assume that
>   filesystem does support UTF8 but command line doesn't.
>   This assumption is obviously not correct in all cases and
>   therefore handling of non-ascii filenames is incomplete.
>   We should file a separate RFE if we need to handle no-ascii
>   filenames by hprof.
> 
> -Dmitry
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]