[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Broken build. Re: RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2014-04-25 16:24:41
Message-ID: 736C2B89-E262-40E3-A106-D3804765836E () oracle ! com
[Download RAW message or body]
It looks like a completely messed this up by not pushing the hotspot parts first and \
now I have broken the build in jdk9-dev.
Should I push an anti-delta of the patch? I can prepare a review of it in a moment.
/Staffan
On 25 apr 2014, at 17:16, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> Thanks Keith!
>
> As far as I can tell there was no good reason for making the bug Confidential, but \
> I can’t undo it. Sorry about that.
> /Staffan
>
> On 25 apr 2014, at 17:02, Keith McGuigan <kmcguigan@twitter.com> wrote:
>
> > Hi Staffan -
> >
> > It looks good to me. Why is the bug marked "closed" though?
> >
> >
> > On Fri, Apr 25, 2014 at 8:56 AM, Staffan Larsen <staffan.larsen@oracle.com> \
> > wrote: Still looking for a Review of this change.
> >
> > Thanks,
> > /Staffan
> >
> > On 7 apr 2014, at 21:19, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> >
> > > And the links:
> > >
> > > bug: https://bugs.openjdk.java.net/browse/JDK-8033104
> > > webrev: http://cr.openjdk.java.net/~sla/8033104/webrev.00/
> > >
> > > Sorry about that,
> > > /Staffan
> > >
> > > On 7 apr 2014, at 20:08, Staffan Larsen <staffan.larsen@oracle.com> wrote:
> > >
> > > >
> > > > The problem here is that the code for finding local VMs is not looking for \
> > > > the data in the correct place.
> > > > When a JVM is started it will create the perf-data file in a user-specific \
> > > > directory inside /tmp (*). The code in the JDK (PerfDataFile.java) that lists \
> > > > all active JVMs looks for the user-specific directory inside java.io.tmpdir. \
> > > > If a user sets -Djava.io.tmpdir on the command line, the code in PerfDataFile \
> > > > will look in the wrong place.
> > > > (*) It's a little bit more complex. /tmp is used on Linux and Solaris. On OS \
> > > > X and Windows, there are user-specific temp directories that should be used, \
> > > > and so the VM queries the OS for these paths.
> > > > The solution would be for PerfDataFile to use the same locations as the VM \
> > > > creates them in. The simplest way to guarantee that the same directory is \
> > > > used is to ask the VM to provide the location. Thus I have introduced a new \
> > > > JVM_ function: JVM_GetTemporaryDirectory.
> > > > (Since this change touches both hotspot and jdk repos I will submit the \
> > > > hotspot part first under a different bug id (provided that the review goes \
> > > > well)).
> > > > The newly added test starts two VM with all possible combinations of setting \
> > > > and not setting java.io.tmpdir to verify that the mechanism is indeed not \
> > > > looking at that variable. I also removed an if-statement in BasicTests.java \
> > > > which would have found this issue a long time ago had it not been there.
> > > > Thanks,
> > > > /Staffan
> > >
> >
> >
> >
> >
> > --
> >
> > Keith McGuigan
> > @kamggg
> > kmcguigan@twitter.com
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;"><div>It looks like a completely messed \
this up by not pushing the hotspot parts first and now I have broken the build in \
jdk9-dev. </div><div><br></div><div>Should I push an anti-delta of the patch? I \
can prepare a review of it in a \
moment.</div><div><br></div><div>/Staffan</div><div><br><div><div>On 25 apr 2014, at \
17:16, Staffan Larsen <<a \
href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta \
http-equiv="Content-Type" content="text/html charset=windows-1252"><div \
style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: \
after-white-space;">Thanks Keith!<div><br></div><div>As far as I can tell there was \
no good reason for making the bug Confidential, but I can’t undo it. Sorry about \
that.</div><div><br></div><div>/Staffan</div><div><br><div><div>On 25 apr 2014, at \
17:02, Keith McGuigan <<a \
href="mailto:kmcguigan@twitter.com">kmcguigan@twitter.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi Staffan \
- <div><br></div><div>It looks good to me. Why is the bug marked "closed" \
though?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr \
25, 2014 at 8:56 AM, Staffan Larsen <span dir="ltr"><<a \
href="mailto:staffan.larsen@oracle.com" \
target="_blank">staffan.larsen@oracle.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Still looking for a Review of this change.<br> <br>
Thanks,<br>
/Staffan<br>
<br>
On 7 apr 2014, at 21:19, Staffan Larsen <<a \
href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>> wrote:<br> \
<br> > And the links:<br>
><br>
> bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8033104" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8033104</a><br> > webrev: \
<a href="http://cr.openjdk.java.net/~sla/8033104/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/~sla/8033104/webrev.00/</a><br> ><br>
> Sorry about that,<br>
> /Staffan<br>
><br>
> On 7 apr 2014, at 20:08, Staffan Larsen <<a \
href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>> wrote:<br> \
><br> >><br>
>> The problem here is that the code for finding local VMs is not looking for \
the data in the correct place.<br> >><br>
>> When a JVM is started it will create the perf-data file in a user-specific \
directory inside /tmp (*). The code in the JDK (PerfDataFile.java) that lists all \
active JVMs looks for the user-specific directory inside java.io.tmpdir. If a user \
sets -Djava.io.tmpdir on the command line, the code in PerfDataFile will look in the \
wrong place.<br>
>><br>
>> (*) It's a little bit more complex. /tmp is used on Linux and Solaris. On OS \
X and Windows, there are user-specific temp directories that should be used, and so \
the VM queries the OS for these paths.<br> >><br>
>> The solution would be for PerfDataFile to use the same locations as the VM \
creates them in. The simplest way to guarantee that the same directory is used is to \
ask the VM to provide the location. Thus I have introduced a new JVM_ function: \
JVM_GetTemporaryDirectory.<br>
>><br>
>> (Since this change touches both hotspot and jdk repos I will submit the \
hotspot part first under a different bug id (provided that the review goes \
well)).<br> >><br>
>> The newly added test starts two VM with all possible combinations of setting \
and not setting java.io.tmpdir to verify that the mechanism is indeed not looking at \
that variable. I also removed an if-statement in BasicTests.java which would have \
found this issue a long time ago had it not been there.<br>
>><br>
>> Thanks,<br>
>> /Staffan<br>
><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><span \
id="docs-internal-guid-6d35c17c-9421-7cb3-ede8-7846b53edbbc"><div dir="ltr" \
style="margin-left:0pt"><table style="border:none;border-collapse:collapse"> \
<colgroup><col width="48"><col width="161"></colgroup><tbody><tr \
style="height:0px"><td style="border-left:solid #000000 0px;border-right:solid \
#000000 0px;border-bottom:solid #000000 0px;border-top:solid #000000 \
0px;vertical-align:top;padding:7px 7px 7px 7px"><div style="text-align: center; \
line-height: 1; margin-top: 0pt; margin-bottom: 0pt;"><img \
src="https://lh5.googleusercontent.com/u6Xn6JDdNN6CNxcDBUqgX0FAbqisyuZDFvP4pAPPuTE6lFi \
z5D3t6_VfDUcwR7TyF6ylFgzbJzj6xQ1FzJq9eqzchQouhQW-hkiRR9woyZ9BxZzJev76dh5S3B_8VIcQJA" \
width="33px;" height="32px;" style="border: none; transform: rotate(0.00rad); \
-webkit-transform: rotate(0.00rad);" alt="twitter-icon-large.png"><span \
style="font-size: 15px; font-family: Arial; background-color: transparent; \
vertical-align: baseline; white-space: pre-wrap;"></span></div> </td><td \
style="border-left:solid #000000 0px;border-right:solid #000000 \
0px;border-bottom:solid #000000 0px;border-top:solid #000000 \
0px;vertical-align:top;padding:7px 7px 7px 7px"><div style="line-height: 1; \
margin-top: 0pt; margin-bottom: 0pt;"> <span style="font-size: 15px; \
background-color: transparent; vertical-align: baseline; white-space: \
pre-wrap;"><font face="tahoma, sans-serif">Keith McGuigan</font></span></div><div \
style="line-height: 1; margin-top: 0pt; margin-bottom: 0pt;"> <span style="font-size: \
12px; background-color: transparent; vertical-align: baseline; white-space: \
pre-wrap;"><font face="tahoma, sans-serif">@kamggg</font></span></div><div \
style="line-height: 1; margin-top: 0pt; margin-bottom: 0pt;"> <a \
href="mailto:kmcguigan@twitter.com" style="text-decoration:none"><span \
style="font-size:12px;color:rgb(17,85,204);background-color:transparent;text-decoration:underline;vertical-align:baseline;white-space:pre-wrap"><font \
face="tahoma, sans-serif">kmcguigan@twitter.com</font></span></a></div> \
</td></tr></tbody></table></div></span><blockquote style="margin:0 0 0 \
40px;border:none;padding:0px"></blockquote></div> </div></div>
</blockquote></div><br></div></div></blockquote></div><br></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic