[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8040167: JDWP spec for ClassType#InvokeMethod contradicts JLS
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2014-04-16 14:58:35
Message-ID: 534E9A9B.7070006 () oracle ! com
[Download RAW message or body]

Also, docs are not normally updated in Update releases. If you need
this updated doc pushed to the web, then you'll need to contact the
docs folks.

Dan


On 4/15/14 3:49 AM, Jaroslav Bachorik wrote:
> Bummer .. I've already pushed the JDK9 fix.
> I didn't realize the CCC was necessary when fixing obviously incorrect 
> doc. Sorry :(
> 
> I will ask for CCC review ASAP.
> 
> -JB-
> 
> On 15.4.2014 11:43, David Holmes wrote:
> > Jaroslav,
> > 
> > Even though a seemingly trivial correction this needs a CCC request.
> > 
> > David
> > 
> > On 15/04/2014 6:21 PM, Jaroslav Bachorik wrote:
> > > Please, review this simple doc change.
> > > 
> > > Issue : https://bugs.openjdk.java.net/browse/JDK-8040167
> > > Webrev: http://cr.openjdk.java.net/~jbachorik/8040167/webrev.00/
> > > 
> > > Currently, the generated JDWP documentation falsely states that the
> > > InvokeMethod command
> > > "Invokes a static method. The method must be member of the class 
> > > type or
> > > one of its superclasses,
> > > *superinterfaces*, or implemented interfaces."
> > > 
> > > Up till JDK8 this was almost non-problem since interfaces could not
> > > specify static methods. For JDK8 this brings in ambiguity and
> > > contradicts JLS.
> > > 
> > > The JDI docs
> > > (http://docs.oracle.com/javase/8/docs/jdk/api/jpda/jdi/com/sun/jdi/ClassType.htm \
> > > l#invokeMethod-com.sun.jdi.ThreadReference-com.sun.jdi.Method-java.util.List-int-) \
> > >  
> > > 
> > > state correctly that the InvokeMethod can be uses only on static 
> > > methods
> > > from the class or its superclasses (no mention of interface) - 
> > > following
> > > the JLS
> > > (http://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.4.8)
> > > rules.
> > > 
> > > The fix is to change the line to read
> > > "Invokes a static method. The method must be member of the class 
> > > type or
> > > one of its superclasses." instead.
> > > 
> > > Thanks,
> > > 
> > > -JB-
> 


[prev in list] [next in list] [prev in thread] [next in thread]