[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): JDK-8038392 Generating prelink cache breaks JAVA 'jinfo' utility normal behavior
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2014-04-07 16:47:53
Message-ID: 5342D6B9.8060801 () oracle ! com
[Download RAW message or body]

Carlos,

Are you OK with proposed changes?

-Dmitry

On 2014-04-07 20:17, Carlos Santos wrote:
> Dmitry,
> 
> You are right. I got confused because a previous version of the patch incorrectly \
> removed the assignment that existed in line 157, so I added it back later. 
> Carlos Santos (casantos)
> Senior *Software* Maintenance Engineer
> (no, I'm not going to fix your roof)
> Red Hat, Inc
> 
> 
> ----- Original Message -----
> > Carlos,
> > 
> > I might be missing something. Sorry about that.
> > 
> > Looking at openjdk7 code
> > 
> > http://hg.openjdk.java.net/jdk7/hotspot/hotspot/file/9b0ca45cd756/agent/src/os/linux/libproc_impl.c
> >  
> > newlib->base is unconditionally initialized at ll. 157
> > 
> > so if we move it after symtab initialization at ll. 181 it shouldn't
> > change things.
> > 
> > -Dmitry
> > 
> > 
> > On 2014-04-07 17:46, Carlos Santos wrote:
> > > Dmitry,
> > > 
> > > The main problem in libproc_impl.c is that newlib->base is left
> > > uninitialized.
> > > 
> > > The check for the name length is just a safety measure. We can live without
> > > it but I'd prefer to avoid the risk.
> > > 
> > > Carlos Santos (casantos)
> > > Senior *Software* Maintenance Engineer
> > > (no, I'm not going to fix your roof)
> > > Red Hat, Inc
> > > 
> > > 
> > > ----- Original Message -----
> > > > Carlos,
> > > > 
> > > > I'd droppend changes in libproc_impl.c as it seems to be not related to
> > > > prelink issue.
> > > > 
> > > > PS:
> > > > 
> > > > (from proposed patch) libproc_impl.c :
> > > > + if (namelen >= sizeof(newlib->name)) {
> > > > 
> > > > sizeof(newlib->name) is PATH_MAX + NAME_MAX
> > > > 
> > > > Are you able to reproduce the issue with too long library name? if yes -
> > > > I'll file the separate CR.
> > > > 
> > > > -Dmitry
> > > > 
> > > > On 2014-04-07 17:16, Carlos Santos wrote:
> > > > > ----- Original Message -----
> > > > > > Hi Everybody,
> > > > > > 
> > > > > > Please review the patch
> > > > > > 
> > > > > > http://cr.openjdk.java.net/~dsamersoff/JDK-8038392/webrev.02/
> > > > > 
> > > > > The fix in agent/src/os/linux/libproc_impl.c contained in my original
> > > > > patch
> > > > > is missing. Was it included in a separate patch?
> > > > > 
> > > > > Carlos Santos (casantos)
> > > > > Senior *Software* Maintenance Engineer
> > > > > (no, I'm not going to fix your roof)
> > > > > Red Hat, Inc
> > > > > 
> > > > 
> > > > 
> > > > --
> > > > Dmitry Samersoff
> > > > Oracle Java development team, Saint Petersburg, Russia
> > > > * I would love to change the world, but they won't give me the sources.
> > > > 
> > 
> > 
> > --
> > Dmitry Samersoff
> > Oracle Java development team, Saint Petersburg, Russia
> > * I would love to change the world, but they won't give me the sources.
> > 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


[prev in list] [next in list] [prev in thread] [next in thread]