[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: JDK 9 RFR of 8038163: Build failure on Mac OS 10.9.2 (Mavericks) due to warning treated as error
From:       Alan Bateman <Alan.Bateman () oracle ! com>
Date:       2014-03-21 20:03:06
Message-ID: 532C9AFA.5000101 () oracle ! com
[Download RAW message or body]

On 21/03/2014 19:50, Brian Burkhalter wrote:
> On Mar 21, 2014, at 12:44 PM, Staffan Larsen<staffan.larsen@oracle.com>  wrote:
>
>> Looks good to me.
> Thanks.
>
>> The version with JNI_TRUE/JNI_FALSE is more correct, but I’m fine with either one.
> Updated to this form:
>
> http://cr.openjdk.java.net/~bpb/8038163/webrev.01/
>
>> (note: this review request should have been sent to serviceability-dev).
> I had no clue to which comp/sub-comp it belongs.
>
> What test would I run to verify this change (other than that if fixes the build)?
>
Looks good to me too. The tests to run are the Java Debug Interface 
(JDI) tests, they are in the jdk_jdi jtreg group.

-Alan.
[prev in list] [next in list] [prev in thread] [next in thread]