[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability
From:       Frederic Parain <frederic.parain () oracle ! com>
Date:       2014-03-05 10:34:23
Message-ID: 5316FDAF.10507 () oracle ! com
[Download RAW message or body]

Thank you for the review.

Fred

On 03/04/2014 03:46 PM, Staffan Larsen wrote:
> Looks good to me!
>
> Thanks,
> /Staffan
>
> On 4 mar 2014, at 12:47, Frederic Parain <Frederic.Parain@oracle.com> wrote:
>
>> Here's an updated webrev:
>> http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
>>
>> Same testing as for the initial version.
>>
>> Thank you,
>>
>> Fred
>>
>> On 03/03/2014 10:32 PM, Alan Bateman wrote:
>>> On 03/03/2014 10:30, Frederic Parain wrote:
>>>> :
>>>>
>>>> I'd prefer to keep open() and read() as they are,
>>>> for the sake of simplicity. In the unlikely case
>>>> where one of these calls gets interrupted, it would
>>>> simply generate a transient error in the value returned
>>>> by OperatingSystem.getCommittedVirtualMemorySize()
>>>> with a easily identifiable value of -1.
>>> open is okay (as you say, open64 isn't interesting here). On EINTR then
>>> open can fail but it seems be just fifos so probably not a concern with
>>> /proc. However for read then I think we should handle it (I agree with
>>> Martin that it's generally a bug if we don't). I realize it's not a big
>>> issue but might be odd for
>>> getCommittedVirtualMemorySize be intermittently "not supported" .
>>>
>>> -Alan
>>
>> --
>> Frederic Parain - Oracle
>> Grenoble Engineering Center - France
>> Phone: +33 4 76 18 81 17
>> Email: Frederic.Parain@oracle.com
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain@oracle.com
[prev in list] [next in list] [prev in thread] [next in thread]