[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS) 6625574: MemoryMXBean/Pending.java fails: "pending finalization = 0 but expected > 0"
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2014-02-28 12:58:38
Message-ID: 3F7E2914-034A-4737-8F87-64F5EDCF81DE () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan

On 28 feb 2014, at 13:56, Mattias Tobiasson <mattias.tobiasson@oracle.com> wrote:

> Hi,
> Could you please review this fix?
> 
> The test often fails when run with command line "-Xcomp"
> 
> The test creates some objects and stores them in a local variable in the function. \
> The test expects those objects to survive until they are set to null. The problem \
> seems to be that the optimizer realizes that the objects are never used and removes \
> them before the test expects it. 
> The solution is to move the local variable out to a public static variable. Then \
> the optimizer will not remove it before expected.  
> webrev:
> http://cr.openjdk.java.net/~mtobiass/6625574/webrev.00
> 
> bug:
> https://bugs.openjdk.java.net/browse/JDK-6625574
> 
> Mattias


[prev in list] [next in list] [prev in thread] [next in thread]