[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmt
From: Staffan Larsen <staffan.larsen () oracle ! com>
Date: 2014-02-24 10:17:41
Message-ID: 244E1F17-0104-411E-AE16-CF7027E46A1E () oracle ! com
[Download RAW message or body]
On 24 feb 2014, at 10:43, Volker Simonis <volker.simonis@gmail.com> wrote:
> On Mon, Feb 24, 2014 at 10:16 AM, Staffan Larsen
> <staffan.larsen@oracle.com> wrote:
>>
>> On 24 feb 2014, at 09:39, Volker Simonis <volker.simonis@gmail.com> wrote:
>>
>>> Hi Serguei,
>>>
>>> thanks a lot for sponsoring this change.
>>>
>>> It seems that https://bugs.openjdk.java.net/browse/INTJDK-7609362 is
>>> not visible.
>>> Could you please make it readable for everybody.
>>
>> Since it is filed on an internal test suite it’s not possible to make the bug visible to everyone.
>>
>
> OK, thanks. I mis-read Serguei's mail. I thought he wanted to create a
> jdk regression test (altough that's a little complicated because of
> the need to create a native shared library).
Yes, that is the root problem. Working on fixing it…
/Staffan
>
> Regards,
> Volker
>
>> /Staffan
>>
>>>
>>> Thank you and best regards,
>>> Volker
>>>
>>>
>>> On Mon, Feb 24, 2014 at 8:32 AM, serguei.spitsyn@oracle.com
>>> <serguei.spitsyn@oracle.com> wrote:
>>>> The fix has been integrated into the jdk9/hs-rt repo.
>>>>
>>>> I've also filed a qe-test/hotspot Enhancement to integrate the test
>>>> attached to the bug report into the VM SQE test base:
>>>> https://bugs.openjdk.java.net/browse/INTJDK-7609362
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>>
>>>> On 2/20/14 12:04 PM, serguei.spitsyn@oracle.com wrote:
>>>>>
>>>>> Hi Axel,
>>>>>
>>>>> We decided that I will sponsor your change.
>>>>> My current plan is to test and push it over weekend.
>>>>>
>>>>> Thanks,
>>>>> Serguei
>>>>>
>>>>>
>>>>> On 2/20/14 1:05 AM, Siebenborn, Axel wrote:
>>>>>>
>>>>>> Yes, I need a sponsor for this change.
>>>>>> Thanks for the reviews,
>>>>>> Axel
>>>>>>
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Volker Simonis [mailto:volker.simonis@gmail.com]
>>>>>>> Sent: Donnerstag, 20. Februar 2014 09:21
>>>>>>> To: serguei.spitsyn@oracle.com
>>>>>>> Cc: Coleen Phillimore; hotspot-runtime-dev@openjdk.java.net;
>>>>>>> serviceability-dev@openjdk.java.net; Siebenborn, Axel
>>>>>>> Subject: Re: RFR(XS): JDK-8034867 - Object references from expression
>>>>>>> stack
>>>>>>> are not visible as roots via jvmti FollowReferences and HeapDump
>>>>>>>
>>>>>>> Axel is covered by the SAP OCA.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Volker
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Feb 20, 2014 at 6:30 AM, serguei.spitsyn@oracle.com
>>>>>>> <serguei.spitsyn@oracle.com> wrote:
>>>>>>>>
>>>>>>>> It looks good to me too.
>>>>>>>> But does Axel need to sign an OCA ?
>>>>>>>>
>>>>>>>> This is a link to follow:
>>>>>>>> http://openjdk.java.net/contribute/
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Serguei
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On 2/19/14 11:28 AM, Coleen Phillimore wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> This change looks good. Do you need a sponsor?
>>>>>>>> thanks,
>>>>>>>> Coleen
>>>>>>>>
>>>>>>>> On 2/13/14 11:57 AM, Siebenborn, Axel wrote:
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> could I have a review for the following change?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> It adds code to iterate over the slots of the expression stack.
>>>>>>>>
>>>>>>>> Found object references are used as heap roots, the same way as object
>>>>>>>> references in locals slots.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Bug:
>>>>>>>>
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8034867
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>>
>>>>>>>> http://sapjvm.com/as/webrevs/8034867
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Axel
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html \
charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; -webkit-line-break: after-white-space;"><br><div><div>On 24 feb 2014, at \
10:43, Volker Simonis <<a \
href="mailto:volker.simonis@gmail.com">volker.simonis@gmail.com</a>> \
wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div \
style="font-size: 16px; font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Mon, Feb 24, 2014 at 10:16 AM, \
Staffan Larsen<br><<a \
href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>> \
wrote:<br><blockquote type="cite"><br>On 24 feb 2014, at 09:39, Volker Simonis <<a \
href="mailto:volker.simonis@gmail.com">volker.simonis@gmail.com</a>> \
wrote:<br><br><blockquote type="cite">Hi Serguei,<br><br>thanks a lot for sponsoring \
this change.<br><br>It seems that <a \
href="https://bugs.openjdk.java.net/browse/INTJDK-7609362">https://bugs.openjdk.java.net/browse/INTJDK-7609362</a> \
is<br>not visible.<br>Could you please make it readable for \
everybody.<br></blockquote><br>Since it is filed on an internal test suite it’s not \
possible to make the bug visible to everyone.<br><br></blockquote><br>OK, thanks. I \
mis-read Serguei's mail. I thought he wanted to create a<br>jdk regression test \
(altough that's a little complicated because of<br>the need to create a native shared \
library).<br></div></blockquote><div><br></div><div>Yes, that is the root problem. \
Working on fixing it…</div><div><br></div><div>/Staffan</div><br><blockquote \
type="cite"><div style="font-size: 16px; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; \
text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-stroke-width: \
0px;"><br>Regards,<br>Volker<br><br><blockquote \
type="cite">/Staffan<br><br><blockquote type="cite"><br>Thank you and best \
regards,<br>Volker<br><br><br>On Mon, Feb 24, 2014 at 8:32 AM, <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a><br><<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>> \
wrote:<br><blockquote type="cite">The fix has been integrated into the jdk9/hs-rt \
repo.<br><br>I've also filed a qe-test/hotspot Enhancement to integrate the \
test<br>attached to the bug report into the VM SQE test base:<br><a \
href="https://bugs.openjdk.java.net/browse/INTJDK-7609362">https://bugs.openjdk.java.net/browse/INTJDK-7609362</a><br><br>Thanks,<br>Serguei<br><br><br><br>On \
2/20/14 12:04 PM, serguei.spitsyn@oracle.com wrote:<br><blockquote type="cite"><br>Hi \
Axel,<br><br>We decided that I will sponsor your change.<br>My current plan is to \
test and push it over weekend.<br><br>Thanks,<br>Serguei<br><br><br>On 2/20/14 1:05 \
AM, Siebenborn, Axel wrote:<br><blockquote type="cite"><br>Yes, I need a sponsor for \
this change.<br>Thanks for the reviews,<br>Axel<br><br><br><blockquote \
type="cite">-----Original Message-----<br>From: Volker Simonis \
[mailto:volker.simonis@gmail.com]<br>Sent: Donnerstag, 20. Februar 2014 09:21<br>To: \
serguei.spitsyn@oracle.com<br>Cc: Coleen Phillimore; \
hotspot-runtime-dev@openjdk.java.net;<br>serviceability-dev@openjdk.java.net; \
Siebenborn, Axel<br>Subject: Re: RFR(XS): JDK-8034867 - Object references from \
expression<br>stack<br>are not visible as roots via jvmti FollowReferences and \
HeapDump<br><br>Axel is covered by the SAP \
OCA.<br><br>Thanks,<br>Volker<br><br><br>On Thu, Feb 20, 2014 at 6:30 AM, \
serguei.spitsyn@oracle.com<br><serguei.spitsyn@oracle.com> \
wrote:<br><blockquote type="cite"><br>It looks good to me too.<br>But does Axel need \
to sign an OCA ?<br><br>This is a link to \
follow:<br> http://openjdk.java.net/contribute/<br><br><br>Thanks,<br>Serguei<br><br><br><br>On \
2/19/14 11:28 AM, Coleen Phillimore wrote:<br><br><br>This change looks good. \
Do you need a sponsor?<br>thanks,<br>Coleen<br><br>On 2/13/14 11:57 AM, \
Siebenborn, Axel wrote:<br><br>Hi all,<br><br>could I have a review for the following \
change?<br><br><br><br>It adds code to iterate over the slots of the expression \
stack.<br><br>Found object references are used as heap roots, the same way as \
object<br>references in locals \
slots.<br><br><br><br>Bug:<br><br>https://bugs.openjdk.java.net/browse/JDK-8034867<br> \
<br><br><br>Webrev:<br><br>http://sapjvm.com/as/webrevs/8034867<br><br><br><br>Thanks, \
<br><br>Axel</blockquote></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote></div></blockquote></div><br></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic