[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Codereview request: 8035195 demo/jvmti/mtrace/TraceJFrame.java can't connect to X11
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2014-02-20 8:47:10
Message-ID: 5305C10E.4060704 () oracle ! com
[Download RAW message or body]

On 20.2.2014 09:05, Staffan Larsen wrote:
> Looks like an OK change although it does not fix the issue with test failures that \
> we see. For that, someone in SQE needs to look at the environment and make sure the \
> tests is run correctly. 
> I suggest you leave the current bug open and create a new one for this test output \
> change.
+1

-JB-

> 
> /Staffan
> 
> On 19 feb 2014, at 09:17, shanliang <shanliang.jiang@oracle.com> wrote:
> 
> > Hi,
> > 
> > The failure was from a bad DISPLAY setting, this must be not intended, so we \
> > re-throw the exception and tell to make sure that the DISPLAY is correct. 
> > The fix is only to add a catch of InternalError at the beginning, the rest code \
> > is not modified but re-formated to remove some spaces. 
> > webrev:
> > http://cr.openjdk.java.net/~sjiang/JDK-8035195/00 \
> > <http://cr.openjdk.java.net/%7Esjiang/JDK-8035195/00>/ 
> > bug:
> > https://bugs.openjdk.java.net/browse/JDK-8035195
> > 
> > 
> > Thanks,
> > Shanliang
> 


[prev in list] [next in list] [prev in thread] [next in thread]