[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: Review Request (S) 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of boun
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2013-05-30 18:18:04
Message-ID: 51A797DC.10109 () oracle ! com
[Download RAW message or body]

Hi Vladimir,

Thank you for the review!
I'll update the test according to your suggestion before the push.

Thanks,
Serguei

On 5/30/13 11:10 AM, Vladimir Kozlov wrote:
> Sergey,
>
> The fix is good.
>
> You don't need to show the failure output in the test sources since 
> you have bugid in it.
>
> Also you don't need /othervm if you don't have command line flags.
>
> Vladimir
>
> On 5/30/13 10:29 AM, serguei.spitsyn@oracle.com wrote:
>>
>> Thanks, Chris!
>> Serguei
>>
>> On 5/30/13 8:41 AM, Christian Thalinger wrote:
>>> Looks good.  -- Chris
>>>
>>> On May 29, 2013, at 9:08 PM, serguei.spitsyn@oracle.com wrote:
>>>
>>>> Please, review the fix and unit test for:
>>>>   bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
>>>>   jbs:  https://jbs.oracle.com/bugs/browse/JDK-8015436
>>>>
>>>> Open webrev:
>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8015436-JVMTI-JSR292.1 
>>>>
>>>>
>>>>
>>>> Summary:
>>>>   The InstanceKlass _initial_method_idnum value must be adjusted as
>>>> necessary if the overpass methods are added.
>>>>   I guess, it is Ok to integrate a unit test covering the fix under
>>>> the same bug id.
>>>>
>>>> Testing:
>>>>   Newly added hotspot unit test: compiler/8015436/Test8015436.java
>>>>   The originally failed test:    compiler/ciReplay/TestSA.sh
>>>>   The vm/mlvm tests
>>>>
>>>> Thanks,
>>>> Serguei
>>

[prev in list] [next in list] [prev in thread] [next in thread]