[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order with lock MethodData
From:       Markus Grönlund <markus.gronlund () oracle ! com>
Date:       2013-02-26 7:53:24
Message-ID: b65419b8-7834-4590-9698-f8496d9261c3 () default
[Download RAW message or body]

Looks good Staffan (not a Reviewer).

Thanks
Markus

-----Original Message-----
From: Staffan Larsen 
Sent: den 18 februari 2013 11:16
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RFR(S): 8005572: fatal error: acquiring lock JfrBuffer_lock/19 out of order \
with lock MethodData_lock/19 -- possible deadlock

Please review this change for hs24 / jdku.

webrev: http://cr.openjdk.java.net/~sla/8005572/webrev.00/

The problem lies with the order of the newly introduced JfrBuffer_lock and \
JfrStream_lock compared to the MethodData_lock. There are cases where we need to take \
the Jfr* locks while holding the MethodData_lock. Ths solution is simply to increase \
the lock order for the Jfr* locks. This change has baked for a while in internal \
testing and showed no regressions.

Thanks,
/Staffan


[prev in list] [next in list] [prev in thread] [next in thread]