[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8000973: SA on windows thread inspection is broken
From:       Yumin Qi <yumin.qi () oracle ! com>
Date:       2013-01-31 19:12:33
Message-ID: 510AC221.6040904 () oracle ! com
[Download RAW message or body]

Serguei,

   Thanks

Yumin

On 1/31/2013 11:10 AM, serguei.spitsyn@oracle.com wrote:
> Hi Yumin,
>
> Looks good.
>
> A couple of minor comments.
>
> 1. All the copyright comments are outdated.
>
> 2.
> *   
> agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
> ***   
> agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java
> **
>    37   //The address argument must be the address of the OSThread::_thread_id
>  Space is missed at the beginning of comment.
>
>    39     this.debugger = debugger;
> *   40     this.sysId   =  (long)addr.getCIntegerAt(0, 4, true);*
>  The '=' is not aligned properly and extra space after '='.
>
>
> Thanks,
> Serguei
>
>
> On 1/30/13 11:16 PM, Yumin Qi wrote:
>> Please have your comments on:
>>
>> http://cr.openjdk.java.net/~minqi/8000973/
>>
>> This only affected Windows platform.
>>
>> Summary: After bug 7161732, On Windows SA could not find correct 
>> address of thread_id of OSThread since _thread_id moved to end of the 
>> class . The presupposition of the address is following thread handle 
>> no longer stands. Fix by adding thread_id field to OSThread and 
>> getting the  address directly from OSThread.
>> Reviewed-by:
>> Contributed-by: yumin.qi@oracle.com
>>
>> Thanks
>> Yumin
>

[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Serguei,<br>
    <br>
      Thanks<br>
    <br>
    Yumin<br>
    <br>
    On 1/31/2013 11:10 AM, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:  \
<blockquote cite="mid:510AC199.8020307@oracle.com" type="cite">  <meta \
content="text/html; charset=UTF-8" http-equiv="Content-Type">  <div \
class="moz-cite-prefix">Hi Yumin,<br>  <br>
        Looks good.<br>
        <br>
        A couple of minor comments.<br>
        <br>
        1. All the copyright comments are outdated.<br>
        <br>
        2.<br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <b>  
agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java<br>
  </b><b><b>  
agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java<br>
          </b></b><br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre><span class="changed">  37   //The address argument must be the address \
of the OSThread::_thread_id</span></pre>  Space is missed at the beginning of \
comment.<br>  <br>
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <pre>  39     this.debugger = debugger;
<font color="#3333ff"><b><span class="changed">  40     this.sysId   =  \
(long)addr.getCIntegerAt(0, 4, true);</span></b></font> </pre>
         The '=' is not aligned properly and extra space after '='.<br>
        <br>
        <br>
        Thanks,<br>
        Serguei<br>
        <br>
        <br>
        On 1/30/13 11:16 PM, Yumin Qi wrote:<br>
      </div>
      <blockquote cite="mid:510A1A36.5010608@oracle.com" type="cite">Please

        have your comments on: <br>
        <br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Eminqi/8000973/">http://cr.openjdk.java.net/~minqi/8000973/</a>
  <br>
        <br>
        This only affected Windows platform. <br>
        <br>
        Summary: After bug 7161732, On Windows SA could not find correct
        address of thread_id of OSThread since _thread_id moved to end
        of the class . The presupposition of the address is following
        thread handle no longer stands. Fix by adding thread_id field to
        OSThread and getting the  address directly from OSThread. <br>
        Reviewed-by: <br>
        Contributed-by: <a moz-do-not-send="true"
          class="moz-txt-link-abbreviated"
          href="mailto:yumin.qi@oracle.com">yumin.qi@oracle.com</a> <br>
        <br>
        Thanks <br>
        Yumin <br>
      </blockquote>
      <br>
    </blockquote>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic