[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RFR(XXS): 8007084: EnableTracing asserts in non-product builds
From: Markus Grönlund <markus.gronlund () oracle ! com>
Date: 2013-01-30 15:08:22
Message-ID: 44e72377-2fba-45d1-a4f1-07aa4d274475 () default
[Download RAW message or body]
Greetings,
Asking for review and putback sponsorship for the following very simple fix:
Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007084
Webrev: http://cr.openjdk.java.net/~mgronlun/8007084/webrev01/
Comment: The effect of this fix is that stringStream will now always assign a valid \
timestamp upon constructing its outputStream. The impact of this is considered to be \
minimal. I elaborated with adding additional constructors to stringStream with \
options for enabling timestamping, but this proved cumbersome, there is already a \
default constructor taking a size_t for initial size. In addition, adding new \
constructors would mean chasing down the oop::print_string, oop::print_on, \
oop::print_value_on chains and updating all stringStream alloc sites. Since the \
timestamp field is already in outputStream, I made this tradeoff for this bugfix \
instead - which I believe will have little impact in practice.
Cheers
Markus
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=iso-8859-1"><meta name=Generator content="Microsoft Word \
12 (filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=SV link=blue vlink=purple><div \
class=WordSection1><p class=MsoNormal>Greetings,<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span lang=EN-US>Asking for \
review and putback sponsorship for the following very simple \
fix:<o:p></o:p></span></p><p class=MsoNormal><span \
lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Bugid: <a \
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007084">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007084</a><o:p></o:p></span></p><p \
class=MsoNormal>Webrev: <span lang=EN-US><a \
href="http://cr.openjdk.java.net/~mgronlun/8007084/webrev01/"><span \
lang=SV>http://cr.openjdk.java.net/~mgronlun/8007084/webrev01/</span></a></span><o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span lang=EN-US>Comment: The \
effect of this fix is that stringStream will now always assign a valid timestamp upon \
constructing its outputStream. The impact of this is considered to be minimal. I \
elaborated with adding additional constructors to stringStream with options for \
enabling timestamping, but this proved cumbersome, there is already a default \
constructor taking a size_t for initial size. In addition, adding new constructors \
would mean chasing down the oop::print_string, oop::print_on, oop::print_value_on \
chains and updating all stringStream alloc sites. Since the timestamp field is \
already in outputStream, I made this tradeoff for this bugfix instead – which I \
believe will have little impact in practice.<o:p></o:p></span></p><p \
class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span \
lang=EN-US>Cheers<o:p></o:p></span></p><p class=MsoNormal><span \
lang=EN-US>Markus<o:p></o:p></span></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic