[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RFR(S): 7079093 & 7073626: cygwin problems in tests
From:       Dmitry.Samersoff () oracle ! com (Dmitry Samersoff)
Date:       2012-02-24 19:46:27
Message-ID: 4F47E913.8070501 () oracle ! com
[Download RAW message or body]

Staffan,

Looks good for me!

-Dmitry


On 2012-02-24 20:12, Staffan Larsen wrote:
> Please review the following changes:
> 
> webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/
> 
> This is a combo review for the following two bugs (although I will push
> as two changes):
> 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079093
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7073626
> 
> 
> The first problem is to recognize cygwin as a valid platform and to set
> up the SystemRoot environment variable (which can be called SYSTEMROOT)
> in some cases.
> 
> The second problem is that some versions of cygwin (or at least some
> installations of cygwin) will add extra newlines when cat:ing files, so
> I remove those.
> 
> The fixes passes JRPT runs.
> 
> Thanks,
> /Staffan


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...

[prev in list] [next in list] [prev in thread] [next in thread]