[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Code Review Request: CR 6988099 Add version information to jvmti demos.
From:       zhengyu.gu () oracle ! com (Zhengyu Gu)
Date:       2011-09-30 13:28:22
Message-ID: 4E85C3F6.3000602 () oracle ! com
[Download RAW message or body]

Hi All,

Could you please help with code review? After that, I can help to push 
to jdk8.

Thanks,

-Zhengyu

On 9/19/2011 2:43 AM, Sean Chou wrote:
> Thanks to Gu and Neil.
> 
> 2011/9/16 Zhengyu Gu <zhengyu.gu at oracle.com 
> <mailto:zhengyu.gu at oracle.com>>
> 
> Okay, once review is completed, I would help you to push to jdk8.
> 
> Thanks,
> 
> -Zhengyu
> 
> 
> On 9/15/2011 2:51 PM, Neil Richards wrote:
> 
> On Thu, 2011-09-15 at 12:14 -0400, Zhengyu Gu wrote:
> 
> No progress been made. Any reason should be resolved right
> away?
> 
> Thanks,
> 
> -Zhengyu
> 
> On 9/15/2011 2:50 AM, Sean Chou wrote:
> 
> Hi,
> About this bug, is there any progressing ?
> 
> 
> 2011/6/8 Zhengyu Gu<zhengyu.gu at oracle.com
> <mailto:zhengyu.gu at oracle.com>>
> No, I did not make any progress on 6988099, as
> it was
> deferred to JDK8. With Dan's comment, looks
> good to me.
> 
> Thanks,
> 
> -Zhengyu
> 
> I've made a couple of modifications to Sean's suggested change, in
> response to Dan's comments:
> 
> * For Windows, added '$(DEMO_VERSION_INFO)' to
> 'LDLIBS.demo', so
> that the line of the link command doesn't need to be
> modified,
> and so 'DEMO_VERSION_INFO' isn't used outside a
> windows-specific
> context.
> * Wrapped the definition of 'RC_FLAGS' in a windows-specific
> block.
> 
> I've uploaded the resulting webrev for your review and
> blessing [1].
> 
> If you're happy with change, I'll look to commit it up into
> jdk8/build/jdk
> 
> Regards, Neil
> 
> [1] http://cr.openjdk.java.net/~ngmr/6988099/webrev.00
> <http://cr.openjdk.java.net/%7Engmr/6988099/webrev.00>
> 
> 
> 
> 
> -- 
> Best Regards,
> Sean Chou
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110930/2e83967e/attachment.html \



[prev in list] [next in list] [prev in thread] [next in thread]