[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    code review for very small jstat fix (7005984)
From:       daniel.daugherty () oracle ! com (Daniel D !  Daugherty)
Date:       2010-12-24 4:33:15
Message-ID: 4D14228B.1060005 () oracle ! com
[Download RAW message or body]

Kelly, David and Poonam,

Thanks for the reviews!

Dan


On 12/23/2010 6:04 PM, Kelly O'Hair wrote:
> Not that I completely understand this change, but it looks like it 
> makes sense.
>
> -kto

On 12/23/2010 6:15 PM, David Holmes wrote:
 > Looks okay to me.
 >
 > David

On 12/23/2010 6:50 PM, Poonam Bajaj wrote:
 > Looks good to me.
 >
 > Thanks,
 > Poonam

>
> On Dec 23, 2010, at 3:25 PM, Daniel D. Daugherty wrote:
>
>> Greetings,
>>
>> I need a code review for a very small jstat fix:
>>
>>   http://cr.openjdk.java.net/~dcubed/7005984-webrev/0/
>>
>> It's going to take me longer to remember how to run the
>> associated tests in JPRT than it is to review this 3 line fix...
>>
>> Dan
>

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic