[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    need a code review for a quick test fix (6971847)
From:       daniel.daugherty () oracle ! com (Daniel D !  Daugherty)
Date:       2010-07-25 16:36:08
Message-ID: 4C4C67F8.5070902 () oracle ! com
[Download RAW message or body]

On 7/25/2010 4:48 AM, Alan Bateman wrote:
> Daniel D. Daugherty wrote:
>> :
>> Yes, I would prefer that the test code be the same across
>> releases. Thanks for approval for OpenJDK6.
> It makes sense to use the same test for jdk6 and jdk7 but it's not 
> clear to me that these tests are useful for the older proprietary 
> releases. For starters, we didn't have -histo:live so the test will 
> fail. Also, I think Windows will bite you again because we didn't 
> include jmap on Windows until jdk6. My guess is you'll need a 
> completely different test. Anyway, as I said, I don't have any 
> objection to the proposed test changes and I'm just pointing you that 
> we shouldn't need any of this detection code in the tests checked into 
> the jdk6 and jdk7 repos.

Thanks Alan!

Dan


[prev in list] [next in list] [prev in thread] [next in thread]