[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to
From:       Alan.Bateman () Sun ! COM (Alan Bateman)
Date:       2009-08-28 4:54:06
Message-ID: 4A9762EE.40009 () sun ! com
[Download RAW message or body]

Daniel D. Daugherty wrote:
>
>
> :
> Shouldn't this:
>
> 173         b[expected] = '\0'; /* ensure null-terminated */
>
> be this:
>
> 173         b[received] = '\0'; /* ensure null-terminated */
>
> To cover the case of a short receive count...
They are the equal at this point because the read loop has read the 
number of expected bytes. If the expected number of the bytes isn't 
received then it is caught by the inter-byte timeout. However, in terms 
of readability, you have a point - thanks Dan!

-Alan.


[prev in list] [next in list] [prev in thread] [next in thread]