[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-security-dev
Subject:    Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryp
From:       Julian Waters <jwaters () openjdk ! org>
Date:       2022-07-21 2:09:45
Message-ID: -W7gOUCmcUOFhZP9HQRte7EhjmQLSM_PGGAcjJWIwG0=.3148e3d2-83a6-4437-8f2f-3985a28d59a1 () github ! com
[Download RAW message or body]

On Wed, 13 Jul 2022 16:40:48 GMT, Valerie Peng <valeriep@openjdk.org> wrote:

> > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just my \
> > > .02.
> > 
> > The only change to pkcs11.h is in a comment though, the other changes are outside \
> > the ANSI C headers from the standard. Should I just revert the comment in that \
> > case?
> 
> > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just my \
> > > .02.
> > 
> > The only change to pkcs11.h is in a comment though, the other changes are outside \
> > the ANSI C headers from the standard. Should I just revert the comment in that \
> > case?
> 
> Sounds good to me.
> Will take a look at the rest of changes in a day or two.
> Thanks!

@valeriepeng Might need you to sponsor this, thanks for the review!

-------------

PR: https://git.openjdk.org/jdk/pull/9353


[prev in list] [next in list] [prev in thread] [next in thread]