[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-security-dev
Subject:    Re: [RFR] 8233404: System property to set the number of PBE iterations in JCEKS keystores
From:       Weijun Wang <weijun.wang () oracle ! com>
Date:       2019-11-12 6:24:53
Message-ID: 44F89AE2-77E0-45C6-BE1C-3120BF56A1C5 () oracle ! com
[Download RAW message or body]

Everything looks fine.

But please hold on for a little while, the CSR is still not approved yet.

Thanks,
Max

> On Nov 12, 2019, at 11:38 AM, Martin Balao <mbalao@redhat.com> wrote:
> 
> Hi Max,
> 
> Thanks for your review.
> 
> On 11/9/19 5:25 AM, Weijun Wang wrote:
> > I added my name as a CSR reviewer and your code change looks fine.
> > 
> > One nit, if it were me, I would throw an exception in "CLIENT" mode and let \
> > executeCommand() to test for .shouldHaveExitValue(0). It's up to you to decide \
> > which is better. 
> 
> I've taken this comment into Webrev.03:
> http://cr.openjdk.java.net/~mbalao/webrevs/8233404/8233404.webrev.03/
> 
> If there are no further objections, I'll push Webrev.03.
> 
> Kind regards,
> Martin.-
> 


[prev in list] [next in list] [prev in thread] [next in thread]