[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-security-dev
Subject:    Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma
From:       Chris Hegarty <chris.hegarty () oracle ! com>
Date:       2019-10-04 8:32:22
Message-ID: 6EE5B925-A874-46E7-981F-91B18D3E48AA () oracle ! com
[Download RAW message or body]

Ivan,

> On 4 Oct 2019, at 03:00, Ivan Gerasimov <ivan.gerasimov@oracle.com> wrote:
> 
> ...
> 
> I've adopted your suggested changes and the test:
> http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/ \
> <http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/>

LGTM.

> CSR was also updated accordingly:
> https://bugs.openjdk.java.net/browse/JDK-8231805 \
> <https://bugs.openjdk.java.net/browse/JDK-8231805>

I added myself as reviewer.

-Chris.


[Attachment #3 (unknown)]

<html><head><meta http-equiv="Content-Type" content="text/html; \
charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: \
space; line-break: after-white-space;" class="">Ivan,<br class=""><div><br \
class=""><blockquote type="cite" class=""><div class="">On 4 Oct 2019, at 03:00, Ivan \
Gerasimov &lt;<a href="mailto:ivan.gerasimov@oracle.com" \
class="">ivan.gerasimov@oracle.com</a>&gt; wrote:</div><br \
class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, \
0);" class="">...</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; \
font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; \
letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; \
white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; \
float: none; display: inline !important;" class="">I've adopted your suggested \
changes and the test:</span><br style="caret-color: rgb(0, 0, 0); font-family: \
Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; \
font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; \
text-transform: none; white-space: normal; word-spacing: 0px; \
-webkit-text-stroke-width: 0px; text-decoration: none;" class=""><a \
href="http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/" \
class="">http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/</a><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""></div></blockquote><div><br class=""></div><div>LGTM.</div><br \
class=""><blockquote type="cite" class=""><div class=""><span style="caret-color: \
rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: \
inline !important;" class="">CSR was also updated accordingly:</span><br \
style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; \
font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: \
normal; text-align: start; text-indent: 0px; text-transform: none; white-space: \
normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8231805" \
style="font-family: Helvetica; font-size: 14px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: \
auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; \
widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; \
-webkit-text-stroke-width: 0px;" \
class="">https://bugs.openjdk.java.net/browse/JDK-8231805</a><br style="caret-color: \
rgb(0, 0, 0); font-family: Helvetica; font-size: 14px; font-style: normal; \
font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: \
start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: \
0px; -webkit-text-stroke-width: 0px; text-decoration: none;" \
class=""></div></blockquote></div><br class=""><div class="">I added myself as \
reviewer.</div><div class=""><br class=""></div><div \
class="">-Chris.</div></body></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic