[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-security-dev
Subject:    Re: [13] RFR JDK-8218780 "Update MUSCLE PCSC-Lite header files"
From:       Seán_Coffey <sean.coffey () oracle ! com>
Date:       2019-02-25 20:49:16
Message-ID: 45537743-251c-0ec7-df04-4d2e8196a654 () oracle ! com
[Download RAW message or body]

Looks fine to me Valerie.

regards,
Sean.

On 15/02/2019 20:04, Valerie Peng wrote:
> Hi Sean (Coffey),
>
> Can you please help reviewing this fix? It's about updating the PC/SC 
> lite header files under the MUSCLE directory inside smartcardio 
> module. The header files are from https://pcsclite.apdu.fr/ and minor 
> adjustments are made to pcsc_md.h and pcsc.c to match the header 
> update and replace the old types, i.e. LPTSTR/LPCTSTR, with new ones 
> to avoid compilation fails on MacOs.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8218780
>
> Webrev: http://cr.openjdk.java.net/~valeriep/8218780/webrev.00/
>
> Mach5 run is clean.
>
> Thanks,
> Valerie
[prev in list] [next in list] [prev in thread] [next in thread]