[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-security-dev
Subject:    Re: RFR 9: 8169416: SSLSessionImpl finalize overhead
From:       Xuelei Fan <Xuelei.Fan () Oracle ! Com>
Date:       2016-11-23 0:21:32
Message-ID: 414AD697-091E-4F82-B17F-9B101D39858B () Oracle ! Com
[Download RAW message or body]

Looks fine to me.

Thanks,
Xuelei

> On 23 Nov 2016, at 5:41 AM, Roger Riggs <Roger.Riggs@oracle.com> wrote:
> 
> Adding security-dev...
> 
> Please review this change to remove an ineffective finalizer for SSLSessions.
> The finalizer removes bindings from the SSLSession of a table that is also
> freed when the SSLSession is being freed. There is no point in removing them explicitly.
> It only delays freeing memory and increases the overhead due to the tracking
> of finalizable objects.  Details are in the issue.
> 
> Webrev:
>  http://cr.openjdk.java.net/~rriggs/webrev-ssl-finalize-8169416
> 
> Issue:
>  https://bugs.openjdk.java.net/browse/JDK-8169416
> 
> Thanks, Roger
>> 
> 

[prev in list] [next in list] [prev in thread] [next in thread]