[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-ppc-aix-port-dev
Subject:    Re: <AWT Dev> Proposal:AIX's IME support
From:       Ichiroh Takiguchi <takiguc () linux ! vnet ! ibm ! com>
Date:       2018-04-18 9:17:27
Message-ID: 8663d11893863e3e63d4671b02ff01f5 () linux ! vnet ! ibm ! com
[Download RAW message or body]

Hello Magnus and Christoph.

I think it's not easy to merge AIX IME support code without current code 
changes...

On 2018-04-18 17:34, Magnus Ihse Bursie wrote:
>> 18 apr. 2018 kl. 09:08 skrev Langer, Christoph 
>> <christoph.langer@sap.com>:
>> 
>> Hi Ichiroh,
>> 
>> I just wanted to let you know that I'm currently working with your 
>> patch, e.g. test this on AIX.
>> 
>> As I've written to you in direct mails, I don't really like that so 
>> much code is duplicated into the AIX subfolders. This can eventually 
>> lead to the fact that somebody does fixes in the common branch and AIX 
>> will miss it.
> 
> I agree, this is highly unfortunate. :-( We've been paying the price
> for a long time for duplicated code across platforms. Let's not
> repeat the same mistake for AIX.
> 
> While it seems "safe" for the platform proponent at the moment
> ("I'm only touching my platform!"), it's a loss for the
> OpenJDK project as a whole in the future.
> 
> /Magnus
> 
>> I'll try to update your patch a bit to integrate better with the 
>> common codebase.
> 
>> 
>> Best regards
>> Christoph
>> 
>>> -----Original Message-----
>>> From: awt-dev [mailto:awt-dev-bounces@openjdk.java.net] On Behalf Of
>>> Ichiroh Takiguchi
>>> Sent: Montag, 16. April 2018 19:42
>>> To: Sergey Bylokhov <Sergey.Bylokhov@oracle.com>
>>> Cc: awt-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net
>>> Subject: Re: <AWT Dev> Proposal:AIX's IME support
>>> 
>>> Hello.
>>> 
>>> Sorry I'm late.
>>> Christoph Langer helped me to put webrev file into 
>>> cr.openjdk.java.net.
>>> See, http://cr.openjdk.java.net/~clanger/webrevs/8201429.0/
>>> 
>>> Actually, he found *.patch files had unexpected entries, I fixed the
>>> issue.
>>> It seemed that webrev tool could not handle "hg copy" action.
>>> It was reported by,
>>> 
>>> http://mail.openjdk.java.net/pipermail/webrev-dev/2018-April/000145.html
>>> So above webrev file should be fine.
>>> 
>>> Please let me know if you have any question and suggestion about 
>>> webrev
>>> file for
>>> AIX's IME support.
>>> 
>>> Thanks,
>>> Ichiroh Takiguchi
>>> 
>>> On 2018-04-10 07:39, Sergey Bylokhov wrote:
>>>> Hi, Ichiroh.
>>>> Your contribution is welcome. Can you send the change for review as 
>>>> a
>>>> webrev on cr.openjdk.java.net?
>>>> 
>>>> On 09/04/2018 02:09, Ichiroh Takiguchi wrote:
>>>>> Hello,
>>>>> IBM would like to propose another Input Method Framework (IMF)
>>>>> implementation against IBM AIX platform.
>>>>> Same IMF implementation was used by IBM Java8 for AIX.
>>>>> IBM would like to contribute this IMF implementation to OpenJDK
>>>>> project.
>>>>> 
>>>>> AIX's Input Method Editor (IME) working behavior is not same as
>>>>> Linux's and Solaris' one.
>>>>> On OpenJDK JDK9 for AIX, users cannot input any East Asian 
>>>>> character
>>>>> with their locale by this IME.
>>>>> We think this situation is critical.
>>>>> Put modified files under src/java.desktop/aix/* directories in 
>>>>> order
>>>>> not to affect the other unix platform.
>>>>> 
>>>>> I'd like contribute following 4 files:
>>>>> M make/lib/Awt2dLibraries.gmk
>>>>> A src/java.desktop/aix/classes/sun/awt/X11InputMethod.java
>>>>> A src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c
>>>>> A src/java.desktop/aix/native/libawt_xawt/xawt/XlibWrapper.c
>>>>> 
>>>>> We need to apply too many changes including JNI, so we copied
>>>>> following 3 files from unix directory to aix directory:
>>>>> * src/java.desktop/unix/classes/sun/awt/X11InputMethod.java
>>>>> * src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c
>>>>> * src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c
>>>>> Then, we modified them.
>>>>> 
>>>>> I'd appreciate any feedback please, and how I would go about 
>>>>> obtaining
>>>>> a sponsor and contributor?
>>>>> 
>>>>> Thanks,
>>>>> Ichiroh Takiguchi
>>>>> IBM Japan, Ltd.
>>>>> 
>> 

[prev in list] [next in list] [prev in thread] [next in thread]