[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-ppc-aix-port-dev
Subject:    Re: RFR(xs): 8145427: [aix] xlc: wrong flag used to switch off optimization
From:       Thomas_Stüfe <thomas.stuefe () gmail ! com>
Date:       2015-12-16 6:46:09
Message-ID: CAA-vtUyO6YMT6_TfxJgLFTcMyr6XVYUToR4ktq1-=t9AtaryrQ () mail ! gmail ! com
[Download RAW message or body]

Hi David,

thank you!

..Thomas

On Wed, Dec 16, 2015 at 7:21 AM, David Holmes <david.holmes@oracle.com>
wrote:

> Hi Thomas,
>
> This kind of thing goes to build-dev (cc'd) not jdk9-dev (which doesn't
> take code reviews).
>
> I've Reviewed this, and as it is a trivial change, and we're going to put
> it into hs-rt forest, I will sponsor it for you.
>
> Thanks,
> David
>
>
> On 16/12/2015 3:22 AM, Thomas St=C3=BCfe wrote:
>
>> Hi all,
>>
>> this fixes a small typo in flags.m4 for AIX-specific compiler flags
>> introduced with JDK-8032045. Please review and sponsor.
>>
>> The fix itself is trivial, but this is the first time I modified the
>> configure script and I hope all is well. After modifying flags.m4, I ran
>> "bash ./common/bin/autogen.sh".
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8145427
>> webrev:
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8145427-aix-typo-flags.m4/web=
rev.00/webrev/
>>
>> Thank you!
>>
>> ..Thomas
>>
>>

[Attachment #3 (text/html)]

<div dir="ltr">Hi David,<div><br></div><div>thank \
you!</div><div><br></div><div>..Thomas</div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Wed, Dec 16, 2015 at 7:21 AM, David Holmes <span \
dir="ltr">&lt;<a href="mailto:david.holmes@oracle.com" \
target="_blank">david.holmes@oracle.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Thomas,<br> <br>
This kind of thing goes to build-dev (cc&#39;d) not jdk9-dev (which doesn&#39;t take \
code reviews).<br> <br>
I&#39;ve Reviewed this, and as it is a trivial change, and we&#39;re going to put it \
into hs-rt forest, I will sponsor it for you.<br> <br>
Thanks,<br>
David<div class="HOEnZb"><div class="h5"><br>
<br>
On 16/12/2015 3:22 AM, Thomas Stüfe wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Hi all,<br>
<br>
this fixes a small typo in flags.m4 for AIX-specific compiler flags<br>
introduced with JDK-8032045. Please review and sponsor.<br>
<br>
The fix itself is trivial, but this is the first time I modified the<br>
configure script and I hope all is well. After modifying flags.m4, I ran<br>
&quot;bash ./common/bin/autogen.sh&quot;.<br>
<br>
bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8145427" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8145427</a><br> webrev:<br>
<a href="http://cr.openjdk.java.net/~stuefe/webrevs/8145427-aix-typo-flags.m4/webrev.00/webrev/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~stuefe/webrevs/8145427-aix-typo-flags.m4/webrev.00/webrev/</a><br>
 <br>
Thank you!<br>
<br>
..Thomas<br>
<br>
</blockquote>
</div></div></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]