[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-ppc-aix-port-dev
Subject:    RE: PPC64 doesn't define SUPPORTS_NATIVE_CX8 ?
From:       "Lindenmaier, Goetz" <goetz.lindenmaier () sap ! com>
Date:       2014-10-07 7:59:10
Message-ID: 4295855A5C1DE049A61835A1887419CC2CF0D8CB () DEWDFEMB12A ! global ! corp ! sap
[Download RAW message or body]

Hi David, 

sorry, I don't want to claim the merits for this.  I had added and tested that
define in my client where I collect minor fixes we do internally, and thought
I would now submit it along with all of them to still catch 8u40.

Thanks again for pointing this out.

Best regards,
  Goetz

-----Original Message-----
From: David Holmes [mailto:david.holmes@oracle.com] 
Sent: Dienstag, 7. Oktober 2014 07:23
To: Lindenmaier, Goetz; ppc-aix-port-dev@openjdk.java.net
Cc: hotspot-dev developers
Subject: Re: PPC64 doesn't define SUPPORTS_NATIVE_CX8 ?

Hi Goetz,

Apologies that my changes have not yet been pushed (something I hope to 
rectify in the very near future). I see you have now handled this yourself.

David

On 5/06/2014 5:06 PM, Lindenmaier, Goetz wrote:
> Hi David,
>
> thanks for spotting this!  Yes, this should be set.  We also set it
> in our internal VM, somehow it got lost in the port.
>
> It would be great if you could fix this along with your change.
>
> Best regards,
>    Goetz.
>
>
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces@openjdk.java.net] On Behalf Of David Holmes
> Sent: Donnerstag, 5. Juni 2014 00:54
> To: ppc-aix-port-dev@openjdk.java.net
> Cc: hotspot-dev developers
> Subject: PPC64 doesn't define SUPPORTS_NATIVE_CX8 ?
>
> SUPPORTS_NATIVE_CX8 is used by platforms with full 64-bit CAS and
> atomics capability to elide the lock-based Unsafe jlong atomic update
> methods and avoid a runtime VM_Version::supports_cx8() check. I just
> noticed this isn't set for PPC64. Can I assume that is just an
> oversight? I have some changes to the lock-based code in the pipeline
> and can update the PPC64 code at the same time if desired.
>
> Thanks,
> David
>

[prev in list] [next in list] [prev in thread] [next in thread]