[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v8]
From:       Thiago Milczarek Sayao <tsayao () openjdk ! org>
Date:       2024-04-30 20:09:58
Message-ID: NlfJWjOaA9dYNJ4lrOrahbdovBu090h80NRFXMNHeTg=.58f5e3d1-db17-4348-87bb-fec3d0e4d73d () github ! com
[Download RAW message or body]

On Tue, 30 Apr 2024 20:03:18 GMT, Thiago Milczarek Sayao <tsayao@openjdk.org> wrote:

> > Wayland implementation will require EGL. 
> > 
> > EGL works with Xorg as well. The idea is to be EGL first and if it fails, \
> > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. 
> > 
> > See:
> > [Switching the Linux graphics stack from GLX to \
> > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/)
> >  [Prefer EGL to GLX for the GL support on \
> > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540)
> 
> Thiago Milczarek Sayao has updated the pull request incrementally with four \
> additional commits since the last revision: 
> - Rollback file
> - rollback file
> - - Rollback EGL_DEFAULT_DISPLAY
> - Don't trust eglGetDisplay without platform
> - Rollback Use PBuffer as the dummy surface
> - Revert "- Use EGL_DEFAULT_DISPLAY"
> 
> This reverts commit 0c78b7490aae221b8441028323bdfa7803e6252e.

I changed it to use platform specific way to get `EGLDisplay` so `eglGetDisplay` does \
not have to guess the platform (it can guess wrong).

It can be seen by setting `EGL_LOG_LEVEL=debug` (with `eglGetDisplay` it will output \
the guessing part).

I also reverted the Dummy window code change.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1381#issuecomment-2087018281


[prev in list] [next in list] [prev in thread] [next in thread]