[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-openjfx-dev
Subject: Integrated: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text
From: John Hendrikx <jhendrikx () openjdk ! org>
Date: 2024-04-30 18:13:11
Message-ID: p16j1rWDGCJc0XFkY0GDEDP3y8Vqsm8YG04clWlG1nk=.765abc80-6b02-407a-af74-3efcdddd93d5 () github ! com
[Download RAW message or body]
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx <jhendrikx@openjdk.org> wrote:
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each wrapped \
> line into account when calculating where to wrap. This looks okay for text that is \
> left aligned (as the spaces will be trailing the lines and generally aren't a \
> problem, but looks weird with CENTER and RIGHT alignments. Even with LEFT \
> alignment there are artifacts of this behavior, where a line like `AAA BBB CCC` \
> (note the **double** spaces) gets split up into `AAA `, `BBB ` and `CCC`, but if \
> space reduces further, it will wrap **too** early because the space is taken into \
> account (ie. `AAA` may still have fit just fine, but `AAA ` doesn't, so the engine \
> wraps it to `AA` + `A ` or something).
> The fix for this is two fold; first the individual lines of text should not include \
> any trailing spaces into their widths; second, the code that is taking the trailing \
> space into account when wrapping should ignore all trailing spaces (currently it is \
> ignoring all but one trailing space). With these two fixes, the layout in \
> LEFT/CENTER/RIGHT alignments all look great, and there is no more early wrapping \
> due to a space being taking into account while the actual text still would have fit \
> (this is annoying in tight layouts, where a line can be wrapped early even though \
> it looks like it would have fit).
> If it were that simple, we'd be done, but there may be another issue here that \
> needs solving: wrapped aligned TextArea's.
> TextArea don't directly support text alignment (via a setTextAlignment method like \
> Label) but you can change it via CSS.
> For Left alignment + wrapping, TextArea will ignore any spaces typed before a line \
> that was wrapped. In other words, you can type spaces as much as you want, and \
> they won't show up and the cursor won't move. The spaces are all getting appended \
> to the previous line. When you cursor through these spaces, the cursor can be \
> rendered out of the control's bounds. To illustrate, if you have the text `AAA \
> BBB CCC`, and the text gets wrapped to `AAA`, `BBB`, `CCC`, typing spaces before \
> `BBB` will not show up. If you cursor back, the cursor may be outside the control \
> bounds because so many spaces are trailing `AAA`.
> The above behavior has NOT changed, is pretty standard for wrapped text controls, \
> and IMHO does not need further attent...
This pull request has now been integrated.
Changeset: 398f104d
Author: John Hendrikx <jhendrikx@openjdk.org>
URL: https://git.openjdk.org/jfx/commit/398f104d6ba721f4534d6e7afdc903b2384e147f
Stats: 1011 lines in 7 files changed: 762 ins; 231 del; 18 mod
8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text
Reviewed-by: kpk, angorya
-------------
PR: https://git.openjdk.org/jfx/pull/1236
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic