[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]
From:       Ambarish Rapte <arapte () openjdk ! org>
Date:       2024-04-29 17:56:15
Message-ID: LcIcQQ_2dKwlPmT0TmcHJByLMwlYNLBvge1gM57R5Kg=.64a49a0a-0d88-4da9-88f9-d859ecc60987 () github ! com
[Download RAW message or body]

On Mon, 29 Apr 2024 15:47:54 GMT, Oliver Kopp <duke@openjdk.org> wrote:

> > modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java \
> > line 104: 
> > > 102:         int length = text.length();
> > > 103:         start = Utils.clamp(0, start, length);
> > > 104:         end = Utils.clamp(start, end, length);
> > 
> > This is only cleanup and not required for this fix.
> 
> I applied the software engineering principle to leave the code cleaner than seen. \
> (Martin Fowler et all)  
> Should I revert this?

Sorry for not being clear. I just wanted to point out that it is not required for the \
issue fix. Please don't revert. This looks better.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1583488561


[prev in list] [next in list] [prev in thread] [next in thread]