[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-04-26 20:03:56
Message-ID: yif65na4MGFlLjrlduHntdinSv2Gi0Y9OiLAT4iEAXE=.ea2395af-9754-4e4a-a501-6ee757e73d76 () github ! com
[Download RAW message or body]

On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac <duke@openjdk.org> wrote:

> > This PR should fix the issue and cover all relevant cases with new tests.
> > 
> > Note: This involves a small behavior change, as can be seen in \
> > dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With this \
> > change the wraparound behavior is similar to that of the IntegerSpinner.
> 
> drmarmac has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Use direction-dependent modulo arithmetic in DoubleSpinnerValueFactory wrap-around \
> logic

Created https://bugs.openjdk.org/browse/JDK-8331214

@drmarmac would you like to update the javadoc or provide the description of the new \
behavior?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2080043462


[prev in list] [next in list] [prev in thread] [next in thread]