[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex [v3]
From:       Michael =?UTF-8?B?U3RyYXXDnw==?= <mstrauss () openjdk ! org>
Date:       2024-04-26 10:07:39
Message-ID: BqOdVIEYNT2VzsatC8ypX1fodkTZM7wplVLe03Hjve4=.e05f4dcd-f5f0-45ed-b10d-1850677363bc () github ! com
[Download RAW message or body]

On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra <lkostyra@openjdk.org> wrote:

> > JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are no \
> > longer needed. 
> > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I \
> > changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it doesn't \
> > matter much (`IDirect3DDevice9Ex` inherits `IDirect3DDevice` - it was leveraged \
> > to transparently use the Ex device in the backend) but now we don't have the \
> > non-Ex device, so that keeps it a bit more consistent and clear IMO. 
> > Verified by running tests on Windows 11, did not notice any regressions. \
> > Unfortunately I have no way to test this on older systems.
> 
> Lukasz Kostyra has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Change pd3dEx to pd3d9

LGTM

-------------

Marked as reviewed by mstrauss (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1445#pullrequestreview-2024655439


[prev in list] [next in list] [prev in thread] [next in thread]