[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8273657 : TextField: all text content must be selected initially
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-04-25 16:18:38
Message-ID: IOWabONCg8TuaTtq41yyHbVVwYFKlu9LjR8ETz4pdwQ=.9fb28f43-4daf-4710-928d-f369af4b38e9 () github ! com
[Download RAW message or body]

On Thu, 25 Apr 2024 14:26:06 GMT, Karthik P K <kpk@openjdk.org> wrote:

> The text was not getting selected on adding the `TextField` to the scene initially, \
> subsequently removing and adding the `TextField` to the scene selects the entire \
> text present in the `TextField`.  
> Made changes in the `TextFieldBehavior` constructor to select the text on adding \
> the `TextField`. 
> Added unit test to validate the fix

the fix looks good.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1446#pullrequestreview-2023008742


[prev in list] [next in list] [prev in thread] [next in thread]