[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8311895: CSS Transitions [v9]
From:       Michael =?UTF-8?B?U3RyYXXDnw==?= <mstrauss () openjdk ! org>
Date:       2024-03-31 8:14:08
Message-ID: 3t-Dw2xmGBHNhsspGEfEA8Qg5tKbL-FgluGeuRQnEvw=.f1b6e738-7576-4ce5-95b6-7ba3417570c8 () github ! com
[Download RAW message or body]

On Tue, 14 Nov 2023 13:04:35 GMT, John Hendrikx <jhendrikx@openjdk.org> wrote:

> > Michael Strauß has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Test whether two Interpolatable instances are compatible
> 
> modules/javafx.graphics/src/main/java/javafx/css/StyleableDoubleProperty.java line \
> 78: 
> > 76: 
> > 77:         if (transition != null) {
> > 78:             timer = TransitionTimer.run(new TransitionTimerImpl(this, v), \
> > transition);
> 
> Would it be possible to check here if this timer is going to the same target?  Also \
> see other comment about a simplification. 
> if (timer == null || timer.newValue.equals(v))) {
> timer = TransitionTimer.run(new TransitionTimerImpl(this, v), transition);
> }

I've moved the logic to discard redundant transitions to the `StyleableProperty` \
implementation classes.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1545575965


[prev in list] [next in list] [prev in thread] [next in thread]