[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8313138: Horizontal Scrollbar Keyboard enhancement [v4]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-03-29 23:31:48
Message-ID: oLgxSN6fBJfPgzRGR3JVtcwQHBNZbjP7tvNRsBmP4WU=.5b0ae5bc-9526-49bf-8b87-f5d53af29ac1 () github ! com
[Download RAW message or body]

> Adding alt-ctrl-LEFT/RIGHT (option-command-LEFT/RIGHT) key bindings to
> 
> - ListView
> - TreeView
> - TableView
> - TreeTableView
> 
> to support keyboard-only horizontal scrolling.  The main reason for the change is \
> to improve accessibility. 
> NOTE: For controls in right-to-left orientation, the direction is reversed.
> 
> As far as I can tell, these key combinations do not interfere with editing.
> 
> The proposed solution can be further optimized by adding a public method to the \
> VirtualFlow class, something like 
> 
> public void horizontalUnitScroll(boolean right);
> 
> 
> Q: Does this change require a CSR to explain the change in the controls' behavior?  \
> We don't yet have the key bindings documented in /doc-files/behavior 
> Note:
> Jenkins headful test passed on all mac configurations, failed on all linux \
> configurations (master branch failed also, so it is test issue), while windows \
> configuration is not yet available.

Andy Goryachev has updated the pull request incrementally with one additional commit \
since the last revision:

  table view behavior

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1393/files
  - new: https://git.openjdk.org/jfx/pull/1393/files/e2f5345e..05809ca3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=03
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=02-03

  Stats: 77 lines in 2 files changed: 76 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1393.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1393/head:pull/1393

PR: https://git.openjdk.org/jfx/pull/1393


[prev in list] [next in list] [prev in thread] [next in thread]