[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v4]
From:       Martin Fox <mfox () openjdk ! org>
Date:       2024-03-29 16:37:44
Message-ID: 53mM45vJgCofM1pzCnd9zRS4g8GEJ_dplzN7CRDhqlk=.1c6bd23e-6f92-4e16-a20a-c508b060b74b () github ! com
[Download RAW message or body]

On Fri, 23 Feb 2024 21:58:37 GMT, Michael Strauß <mstrauss@openjdk.org> wrote:

> > Platform preferences detection doesn't pick up effective macOS system preferences \
> > if AWT owns the NSApplication and has set its NSAppearance to a fixed value. 
> > The workaround is to set the system property \
> > "apple.awt.application.appearance=system". 
> > If this property is not set, the following warning will be emitted if a JavaFX \
> > application attempts to use the platform preferences API: 
> > 
> > WARNING: Reported preferences may not reflect the macOS system preferences unless \
> > the sytem property apple.awt.application.appearance=system is set. This warning \
> > can be disabled by setting javafx.preferences.suppressAppleAwtWarning=true.
> 
> Michael Strauß has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Break warning message into separate lines

Verified that the settings are working as expected and warning only appears once. \
Looks good to me.

-------------

Marked as reviewed by mfox (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1367#pullrequestreview-1968987071


[prev in list] [next in list] [prev in thread] [next in thread]