[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8273349: Check uses of Stream::peek in controls and replace as needed [v3]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-03-28 22:34:35
Message-ID: 6b6iN2-SiYM7xEUowlXpGIuTxBUh-r5u1VBuxeW1LMw=.475d8893-b01a-4e8e-9e3f-7574284c183b () github ! com
[Download RAW message or body]

On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac <duke@openjdk.org> wrote:

> > This PR removes potentially incorrect usages of Stream.peek().
> > The changed code should be covered by the tests that are already present.
> 
> drmarmac has updated the pull request incrementally with two additional commits \
> since the last revision: 
> - Preallocate in SelectedIndicesList.set()
> - Remove unused import

Thank you for clarifications!

Does not look like this is called from a loop, so whatever inefficiency we have is \
likely to be ok.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1430#pullrequestreview-1967473815


[prev in list] [next in list] [prev in thread] [next in thread]