[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8328746: Remove unused imports in demo apps
From:       Karthik P K <kpk () openjdk ! org>
Date:       2024-03-28 9:07:38
Message-ID: 2i6hyUMSMJeg4vvARKhFe0eJalFOv36Kq7axbSUIitY=.8340f08f-6269-4984-84bb-2e810e054f88 () github ! com
[Download RAW message or body]

On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev <angorya@openjdk.org> wrote:

> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble, etc.) \
> and update the copyright year to 2024. Using wildcard for more than 10 static \
> imports. 
> 
> --
> 
> This is a trivial change (though fairly large), 1 reviewer is probably enough.

Leaving it unspecified would be ok but some kind of soft recommendation could also \
help in my opinion. So there will be a direction for someone who is looking for a \
recommended way to add imports and have consistency class files.

> > static imports (sorted alphabetically)
> > one blank line
> > ordinary imports (sorted alphabetically)
> > No wildcard imports (I favor an exception for static imports).
> 
> +1 for something like this. 

+1 on this and no wildcard imports other than static imports.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1420#issuecomment-2024715556


[prev in list] [next in list] [prev in thread] [next in thread]