[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8328750: [TestBug] Improve Stub Font Support [v3]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-03-27 22:24:35
Message-ID: YzsGzzuvrHsRhACyq2ENSGHXNwBZ50R-jhYS6TMd6H0=.f21c8dd3-b503-4fec-9aac-d5fbae08a052 () github ! com
[Download RAW message or body]

On Wed, 27 Mar 2024 22:20:42 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> > In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings of \
> > the stub font implementation. As I don't want to clutter the PR with that, I \
> > decided to cherrypick the improvements I did to a new ticket and PR. 
> > The current implementation has the following shortcomings:
> > - It does not reliable detect the System Font, as a consequence, tests in \
> >                 TableColumnHeaderTest.java are failing on my local machine
> > - Another consequence of this is, that the font size is always estimated with 0, \
> >                 as it is not detected
> > - One shortcoming currently is, that the stub font siie estimate is not \
> > considering bold fonts. That would improve writing tests for some scenarios, e.g. \
> > for TableColumnHeader, where we would expect that the size of the header is \
> > bigger since it is bold 
> > Some tests were failing for the following reasons:
> > - `AreaChartTest.java` - `expected -30.0, was -30.00000000004` - I added rounding \
> >                 to the data.
> > - `StackedBarChartTest.java` - since we now calculate correctly, the path changed
> > - A test tried to load `Helvetica`, which is not supported in the stub font \
> >                 loader. I changed it
> > - The default System font is considered a `Regular` one (style) - just like in \
> > JavaFX 
> > I wrote tests and documented the stub behaviour.
> > I did some minor changes here:
> > - System font is now detected, also in bold and italic
> > - A bold font will be calculated with a little bit more width (1px). Checkout the \
> > test as well for that 
> > Note: This only changes test setup, no 'production' code.
> 
> Marius Hanl has updated the pull request incrementally with one additional commit \
> since the last revision: 
> improve javadoc

Marked as reviewed by angorya (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1422#pullrequestreview-1964866535


[prev in list] [next in list] [prev in thread] [next in thread]