[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike al
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2024-02-29 19:34:54
Message-ID: 81hctBLahaRrQ3Olb6UxJJP514nlXjdiSCH82J1RJXQ=.1538313b-d677-4a94-9e25-0d47255084a7 () github ! com
[Download RAW message or body]

On Wed, 14 Feb 2024 20:53:46 GMT, Marius Hanl <mhanl@openjdk.org> wrote:

> > modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java line \
> > 421: 
> > > 419:             if (oldIndex == newIndex) {
> > > 420:                 if (!isItemChanged(oldValue, newValue)) {
> > > 421:                     // RT-37054:  we break out of the if/else code here \
> > > and
> > 
> > could we also add (or replace?) the new reference for RT-37054: JDK-8096969
> 
> same as the other comment, I would prefer to do that for all cell implementations \
> in one go. If that is okay for you as well. :)

okay

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1360#discussion_r1508074943


[prev in list] [next in list] [prev in thread] [next in thread]