[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Integrated: 8260013: Snapshot does not work for nodes in a subscene
From:       Lukasz Kostyra <lkostyra () openjdk ! org>
Date:       2024-01-30 7:01:46
Message-ID: lLpA9pHcRU8PXkSabK-owY7p6ac5tsVxP1_wc5mGP9c=.1fb78d74-9817-4ab2-8937-6471453e0198 () github ! com
[Download RAW message or body]

On Fri, 12 Jan 2024 14:11:14 GMT, Lukasz Kostyra <lkostyra@openjdk.org> wrote:

> Originally this issue showed the problem of Node being incorrectly rendered \
> (clipped) when snapshotting, compared to a snapshot of the whole Scene. Later on \
> there was another problem added - lights not being taken into account if they are \
> added to a SubScene. 
> As it later turned out, the original problem from this bug report is a problem with \
> ParallelCamera incorrectly estimating near/far clipping planes, which just happened \
> to reveal itself while snapshotting a Node. During testing I found out you can make \
> the Node clip regardless of snapshot mechanism. Clipping issue was moved to a \
> separate bug report and this PR only fixes the inconsistency in lights being \
> gathered for a snapshot. 
> `Scene.doSnapshot()` was expanded to also check if SubScene provided to it is \
> non-null and to fetch lights assigned to it. Scenario was tested with added \
> SnapshotLightsTest. 
> Rest of the tests were checked and don't produce any noticeable regressions.

This pull request has now been integrated.

Changeset: d653a31c
Author:    Lukasz Kostyra <lkostyra@openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/d653a31c1c1fa486f5042424c4f8e7f0c3b21a17
                
Stats:     181 lines in 5 files changed: 167 ins; 1 del; 13 mod

8260013: Snapshot does not work for nodes in a subscene

Reviewed-by: kcr, mstrauss

-------------

PR: https://git.openjdk.org/jfx/pull/1332


[prev in list] [next in list] [prev in thread] [next in thread]