[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8260013: Snapshot does not work for nodes in a subscene [v4]
From:       Michael =?UTF-8?B?U3RyYXXDnw==?= <mstrauss () openjdk ! org>
Date:       2024-01-30 5:49:41
Message-ID: Lop8P4-Sfdw4kIfx6kr8fl6bVD59mmDi8pRzTiDIrk4=.b81c7014-fb07-4eff-afb8-e3fbafa6b0c2 () github ! com
[Download RAW message or body]

On Mon, 29 Jan 2024 09:32:06 GMT, Lukasz Kostyra <lkostyra@openjdk.org> wrote:

> > Originally this issue showed the problem of Node being incorrectly rendered \
> > (clipped) when snapshotting, compared to a snapshot of the whole Scene. Later on \
> > there was another problem added - lights not being taken into account if they are \
> > added to a SubScene. 
> > As it later turned out, the original problem from this bug report is a problem \
> > with ParallelCamera incorrectly estimating near/far clipping planes, which just \
> > happened to reveal itself while snapshotting a Node. During testing I found out \
> > you can make the Node clip regardless of snapshot mechanism. Clipping issue was \
> > moved to a separate bug report and this PR only fixes the inconsistency in lights \
> > being gathered for a snapshot. 
> > `Scene.doSnapshot()` was expanded to also check if SubScene provided to it is \
> > non-null and to fetch lights assigned to it. Scenario was tested with added \
> > SnapshotLightsTest. 
> > Rest of the tests were checked and don't produce any noticeable regressions.
> 
> Lukasz Kostyra has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Minor review adjustments

Looks good!

-------------

Marked as reviewed by mstrauss (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1332#pullrequestreview-1850271783


[prev in list] [next in list] [prev in thread] [next in thread]