[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8189282: JavaFX: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows [
From:       Martin Fox <mfox () openjdk ! org>
Date:       2023-12-26 23:42:56
Message-ID: RNXixTn_qpq-d5_dRpdI7GkJkOPkow8ofI2zuMWsxjI=.8d6be0c4-5a61-4060-8077-2d9c14ea86a5 () github ! com
[Download RAW message or body]

> When reporting input method candidate position the code in GlassViewEventHandler is \
> not applying the platform scale factors. This is causing incorrect IM positions to \
> be reported to glass on hi-dpi monitors. 
> This PR a no-op on Mac since the platform scale factors are always 1.0. I don't \
> think it affects the current Linux XIM code at all but XIM is so out-of-date it has \
> become difficult to test. PR #1080 will replace the old XIM code and needs this fix \
> to work properly on hi-dpi screens.

Martin Fox has updated the pull request incrementally with one additional commit \
since the last revision:

  IM coordinates are relative to main screen

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1311/files
  - new: https://git.openjdk.org/jfx/pull/1311/files/2e61be93..401f5117

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1311&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1311&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jfx/pull/1311.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1311/head:pull/1311

PR: https://git.openjdk.org/jfx/pull/1311


[prev in list] [next in list] [prev in thread] [next in thread]