[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8089373: Translation from character to key code is not sufficient
From:       Martin Fox <mfox () openjdk ! org>
Date:       2023-12-20 18:52:50
Message-ID: ERHSVIKCfIvLKlk61VePLp8vA6gSBhBPgHA61RfdaXk=.38e17d43-60e7-44ce-8588-71567a2bc057 () github ! com
[Download RAW message or body]

On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox <mfox@openjdk.org> wrote:

> On Windows a common shortcut like Ctrl+'+' could only be invoked from the main \
> keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not have enough \
> context to know whether it should return a result from the main keyboard or the \
> keypad. 
> This PR alters getKeyCodeForChar to pass in the code of the key the system is \
> trying to match against. Only the Windows platform actually uses this additional \
> information. 
> On the Mac the numeric keypad has always worked due to the odd way \
> getKeyCodeForChar is implemented (until PR #1209 the keypad worked more reliably \
> than the main keyboard). On Linux getKeyCodeForChar is a mess; neither the main \
> keyboard or the numeric keypad work reliably. I have an upcoming PR which should \
> make both work correctly.

Commenting to keep the bot at bay.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1289#issuecomment-1864977054


[prev in list] [next in list] [prev in thread] [next in thread]