[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableV
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-12-19 18:54:53
Message-ID: LWEupZT83Vn1QGzvYbemtRGDCUlCTvlDq0d2Xigsfss=.6920b9c7-6e2d-40b0-bf41-db0dd07d73a8 () github ! com
[Download RAW message or body]

On Mon, 18 Dec 2023 15:51:01 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> > This PR fixes an issue when a new `TableColumn` is added to a `TableView` control \
> > with fixed cell size set, where the `TableRowSkinBase` failed to add the cells \
> > for the new column. 
> > A test is included that fails before applying this PR and passes with it.
> 
> Jose Pereda has updated the pull request incrementally with one additional commit \
> since the last revision: 
> address feedback

verified the fix with the SCEE in the ticket as well as with additional manual tests \
in the MonkeyTester. looks good on macOS 14.1.2

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1308#pullrequestreview-1789526626


[prev in list] [next in list] [prev in thread] [next in thread]