[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Withdrawn: 8313709: Wrong layout of a FlowPane in a BorderPane in a ScrollPane, if padding is too bi
From:       duke <duke () openjdk ! org>
Date:       2023-11-30 19:06:20
Message-ID: awQP5UfHVcQec2kpn4yRsgxTmVTmmTzn_w0dFvQcZzU=.a68435a6-053a-4a9f-9451-1925ef8e7022 () github ! com
[Download RAW message or body]

On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda <jpereda@openjdk.org> wrote:

> So far, BorderPane does the calculation for the children min/pref width/height \
> taken into account only the margin applied to them, if any, but not the total \
> padding that could be applied as well to the BorderPane itself. 
> However, this padding needs to be taken into account as well, and this PR modifies \
> BorderPane to subtract its insets from its size while doing the children min/pref \
> width/height calculations. 
> A parameterized test has been included. 
> 
> It is a simplified version of the test case attached to \
> https://bugs.openjdk.org/browse/JDK-8313709, but still shows how without this \
> patch, two of the cases (padding with or without margin) fail, while pass with it.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jfx/pull/1203


[prev in list] [next in list] [prev in thread] [next in thread]