[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-10-31 21:09:44
Message-ID: fi0UGrCDsLBazMcMaOyUiw2BM2agTbJPVLyMmMR9FnI=.0c3b17b9-7f77-40d3-954f-c1efd5d78a14 () github ! com
[Download RAW message or body]

On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox <duke@openjdk.org> wrote:

> > When a window is visible the maximized, iconified, and fullscreen properties are \
> > two-way streets; changes made in Java are sent on to the platform window and \
> > changes in the platform window are sent back into Java. 
> > When a window is hidden these properties (and others, like location and sizing \
> > information) are not sent on to the platform window until the window is made \
> > visible. In other words, the properties don't reflect the actual state of the \
> > window but the intended state after it's shown. 
> > There's a period when the window is transitioning from hidden to shown where the \
> > core Stage code is using the stored properties to configure the platform window \
> > and the platform window is simultaneously calling back in to update the \
> > properties. This was causing the intended state to be wiped out before it could \
> > be sent on to the platform window. 
> > The problem is specific to Mac because on that platform any change to the size or \
> > location of a window can cause it to enter or leave the maximized (zoomed) state. \
> > So just setting the location can cause the maximized flag to be altered. 
> > The proposed solution is to copy the intended state bits to Stage local variables \
> > to be used later in the configuration.
> 
> Martin Fox has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Revert core changes. Fix Mac glass code so it reports maximized state correctly.

SetXYAndMaximize JDK-8316419 works the same with or without the fix, the window \
appears maximized to fill the visible area (excl. the dock and the tool bar):

<img width="1797" alt="Screenshot 2023-10-31 at 14 02 37" \
src="https://github.com/openjdk/jfx/assets/107069028/75469d3d-003e-4416-949d-f948a8a41641">


Is it expected?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1258#issuecomment-1788036894


[prev in list] [next in list] [prev in thread] [next in thread]