[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-openjfx-dev
Subject:    Re: RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors.
From:       Andy Goryachev <angorya () openjdk ! org>
Date:       2023-10-31 20:11:43
Message-ID: NkeEzN-qaWeCm8ApyFctOGVZIgnw4ZANrAxg98kjICc=.252b033d-cf8a-4175-ba0c-600e7d9a5f15 () github ! com
[Download RAW message or body]

On Tue, 19 Sep 2023 22:26:31 GMT, Phil Race <prr@openjdk.org> wrote:

> > The Method javafx.print.getWidth and getHeight returns a double of points.
> > But the values are always rounded to full integers. This causes especially \
> > problems, with mm based Papers.
> > 
> > I asked in the mailing list, with the conclusion (me and John Hendrix) that is \
> > best to just fix this behavior by removing the rounding.
> 
> FX uses doubles as a rule and it doesn't preclude that the actual values may have \
> no fractional part. NA paper is measured in INCHes and if we have some FP error and \
> end up with 792.0001 pts then the rounding would help. So I am not sure about \
> removing it completely.  What exact problem does it cause you ? Paper matching to \
> A4 etc should be working SFAIK. Perhaps we can tweak the MM case only. Not rounding \
> to whole values but a close FP representation.

please wait before integrating this until @prrace has a chance to take another look \
at it.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1244#issuecomment-1787960540


[prev in list] [next in list] [prev in thread] [next in thread]